Opened 5 weeks ago

Last modified 5 weeks ago

#32407 merge_ready defect

Fix crash when calling --dump-config with failing set_options

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: consider-backport-after-0425, 035-backport 040-backport 041-backport 042-backport
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: teor Sponsor: Sponsor31-can

Description

It appears that our cleanup code hits an assertion failure when we have been called with --dump-config and a set of options that fails in set_options().

Child Tickets

Change History (5)

comment:1 Changed 5 weeks ago by nickm

Actual Points: .1
Keywords: 035-backport 040-backport 041-backport 042-backport added

comment:2 Changed 5 weeks ago by nickm

Branch is bug32407 with PR in https://github.com/torproject/tor/pull/1513. It merges forward cleanly to master. Let's take it in master as part of #30866, which needs it to fix its tests.

comment:3 Changed 5 weeks ago by nickm

Reviewer: teor
Status: assignedneeds_review

comment:4 Changed 5 weeks ago by teor

Keywords: consider-backport-after-0425 added
Milestone: Tor: 0.4.3.x-finalTor: 0.4.1.x-final
Status: needs_reviewmerge_ready

Looks good to me. Merged to 0.4.2 and later.
Marking for backport to 0.3.5 and later, once it has been tested in 0.4.2.4.

comment:5 Changed 5 weeks ago by nickm

Parent ID: #30866

Removing parent relationship so parent can close.

Note: See TracTickets for help on using tickets.