Opened 12 months ago

Closed 8 months ago

#32434 closed project (fixed)

Get build changes needed for RLBox into tor-browser-build

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security, GeorgKoppen202001, TorBrowserTeam202002R
Cc: Actual Points:
Parent ID: #32389 Points:
Reviewer: boklm Sponsor:

Description

We need to apply some build changes to our tor-browser-build to be able to compile RLBox and related code later on. This is the parent ticket tracking all of them.

Child Tickets

TicketStatusOwnerSummaryComponent
#32435closedtbb-teamCompile clang for Linux x86_64 with WASM supportApplications/Tor Browser
#32436closedtbb-teamInclude lucetc project into tor-browser-buildApplications/Tor Browser
#32437closedtbb-teamInclude wasi-libc project into tor-browser-buildApplications/Tor Browser
#32526closedtbb-teamEnhance wasi-sysrootApplications/Tor Browser

Change History (8)

comment:1 Changed 11 months ago by gk

Keywords: GeorgKoppen201912 added; GeorgKoppen201911 removed

Moving my tickets to December.

comment:2 Changed 10 months ago by gk

Keywords: GeorgKoppen202001 added; GeorgKoppen201912 removed

No December anymore.

comment:3 Changed 10 months ago by gk

Keywords: TorBrowserTeam202001R added
Status: newneeds_review

Okay, bug_32389 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_32389) is a branch that produces a libgraphitewasm.so in Tor Browser. Thus, the build related parts (in child tickets) are good for review.

I still need to go through all my browser patches and figure out why the built bundle is crashing. Moreover, I think the right way to treat this new feature is to put all the browser patches needed into tor-browser-build, too, as there are a lot of changes and they are pretty big. I would feel more comfortable if all of them are only applied if we build an RLBox enabled bundle. That work will happen #32389, though.

(Setting this ticket in needs_review as all the child tickets are good and for a second pair of eyes for the approach described above.)

Last edited 8 months ago by gk (previous) (diff)

comment:4 Changed 9 months ago by boklm

For a description of RLBox, it seems the main mozilla ticket is:
https://bugzilla.mozilla.org/show_bug.cgi?id=1554268

comment:5 Changed 9 months ago by boklm

Reviewer: boklm

comment:6 Changed 9 months ago by pili

Keywords: TorBrowserTeam202002R added; TorBrowserTeam202001R removed

Moving reviews to February

comment:7 in reply to:  3 Changed 8 months ago by gk

Replying to gk:

Okay, bug_32389 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_32389) is a branch that produces a libgraphitewasm.so in Tor Browser. Thus, the build related parts (in child tickets) are good for review.

I still need to go through all my browser patches and figure out why the built bundle is crashing. Moreover, I think the right way to treat this new feature is to put all the browser patches needed into tor-browser-build, too, as there are a lot of changes and they are pretty big. I would feel more comfortable if all of them are only applied if we build an RLBox enabled bundle. That work will happen #32389, though.

(Setting this ticket in needs_review as all the child tickets are good and for a second pair of eyes for the approach described above.)

The above still applies, however, I have an updated ànd rebased branch with all the patches from #32380, which I am happy with: bug_32389_v5 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v5&id=9de4d318aae0a63c4a61264f6c0d2ec655de944c).

comment:8 Changed 8 months ago by gk

Parent ID: #32379#32389
Resolution: fixed
Status: needs_reviewclosed

I think we are done here. The remaining bits for the build changes will be handled in #32389.

Note: See TracTickets for help on using tickets.