Opened 3 months ago

Closed 6 days ago

Last modified 6 days ago

#32435 closed task (fixed)

Compile clang for Linux x86_64 with WASM support

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security, GeorgKoppen202001, TorBrowserTeam202001R
Cc: Actual Points:
Parent ID: #32434 Points:
Reviewer: Sponsor:

Description

We need to provide WASM support in our clang build (this ticket corresponds to Mozilla's https://bugzilla.mozilla.org/show_bug.cgi?id=1579870).

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by gk

bug_32435_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32435_v2&id=cf4f6b1a7baeb99303c4ce6350eada77147596c3) has a fix for this bug. It's a bit unfortunate that this will rebuild all the clangs (and then all the other stuff that depends on that) but we should have done that reformatting for better readability earlier on. Now seemed to be a good time after not doing that (given that that one line was starting to get unwieldy).

comment:2 Changed 7 weeks ago by gk

Keywords: GeorgKoppen201912 added; GeorgKoppen201911 removed

Moving my tickets to December.

comment:3 Changed 3 weeks ago by gk

Keywords: GeorgKoppen202001 added; GeorgKoppen201912 removed

No December anymore.

comment:4 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam202001R added
Status: newneeds_review

comment:5 in reply to:  4 ; Changed 7 days ago by boklm

Keywords: TorBrowserTeam202001 added; TorBrowserTeam202001R removed
Status: needs_reviewneeds_revision

Replying to gk:

bug_32389 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389&id=298b18f9e1319077e8909b5ec43f270fbfabf405) has a build patch up for review.

One small simplification: I think the line rlbox: '[% c("var/nightly") && c("var/linux-x86_64") %]' can be moved to targets/linux-x86_64 instead of targets/linux, so that the part && c("var/linux-x86_64") can be removed.

We can also remove the lines rlbox: 0 for the other platforms, as it is disabled by default.

With only one place where it is set, I think this makes it easier to see in which case it is enabled.

comment:6 in reply to:  5 ; Changed 7 days ago by gk

Keywords: TorBrowserTeam202001R added; TorBrowserTeam202001 removed
Status: needs_revisionneeds_review

Replying to boklm:

Replying to gk:

bug_32389 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389&id=298b18f9e1319077e8909b5ec43f270fbfabf405) has a build patch up for review.

One small simplification: I think the line rlbox: '[% c("var/nightly") && c("var/linux-x86_64") %]' can be moved to targets/linux-x86_64 instead of targets/linux, so that the part && c("var/linux-x86_64") can be removed.
We can also remove the lines rlbox: 0 for the other platforms, as it is disabled by default.

Done on bug_32389_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v2&id=a1eab9035af5b5d6cc8ab21615676f9f237c074f).

I thought it would make it easier to clarify that the feature actually is disabled on other platforms/architectures, in particular as we e.g. set the snowflake part for Android to 0 explicitly, but fine with me. Should I file a ticket to correct that (and the namecoin: 0 ones)?

comment:7 in reply to:  6 Changed 6 days ago by boklm

Replying to gk:

Replying to boklm:

Replying to gk:

bug_32389 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389&id=298b18f9e1319077e8909b5ec43f270fbfabf405) has a build patch up for review.

One small simplification: I think the line rlbox: '[% c("var/nightly") && c("var/linux-x86_64") %]' can be moved to targets/linux-x86_64 instead of targets/linux, so that the part && c("var/linux-x86_64") can be removed.
We can also remove the lines rlbox: 0 for the other platforms, as it is disabled by default.

Done on bug_32389_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v2&id=a1eab9035af5b5d6cc8ab21615676f9f237c074f).

I thought it would make it easier to clarify that the feature actually is disabled on other platforms/architectures, in particular as we e.g. set the snowflake part for Android to 0 explicitly, but fine with me. Should I file a ticket to correct that (and the namecoin: 0 ones)?

When I want to see if a feature is enabled/disable I usually look at all the lines setting the option, so I find it better to have less lines to look at. An exception would be if we also want to add a comment explaining why it is disabled in such case (but that does not seem to be the case here).

So I would also remove the snowflake and namecoin lines that are not needed.

comment:8 in reply to:  6 Changed 6 days ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

Done on bug_32389_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v2&id=a1eab9035af5b5d6cc8ab21615676f9f237c074f).

Thanks. I merged this to master as commit a1eab9035af5b5d6cc8ab21615676f9f237c074f.

comment:9 Changed 6 days ago by boklm

I opened #33012 for the removal of the namecoin and snowflake lines.

Note: See TracTickets for help on using tickets.