Opened 12 months ago

Closed 8 months ago

#32436 closed task (fixed)

Include lucetc project into tor-browser-build

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security, GeorgKoppen202001, TorBrowserTeam202002R
Cc: Actual Points:
Parent ID: #32434 Points:
Reviewer: boklm Sponsor:

Description (last modified by gk)

We need to create a lucetc project to build a modificed lucetc version, which is currently needed for RLBox (this ticket corresponds to https://bugzilla.mozilla.org/show_bug.cgi?id=1582195)

Child Tickets

Change History (9)

comment:1 Changed 12 months ago by gk

It seems the dependencies are not vendored in which is a bit unfortunate and reminds me at the cbindgen situation. I am not sure what our longer-term plan here is but it seems we need to vendor them in ourselves here, too, to proceed. I guess I could ask at the Mozilla bug, though, given that Mozilla *is* (usually) vendoring in code needed.

Last edited 12 months ago by gk (previous) (diff)

comment:2 Changed 12 months ago by gk

Description: modified (diff)
   Compiling target-lexicon v0.8.1
   Compiling wasmonkey v0.1.8 (/var/tmp/build/lucetc/lucet-builtins/wasmonkey)
error[E0658]: use of unstable library feature 'alloc': this library is unlikely to be stabilized in its current form or name (see issue #27783)
  --> /var/tmp/build/lucetc/vendor/target-lexicon/build.rs:15:1
   |
15 | extern crate alloc;
   | ^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

We likely need a newer Rust compiler than 1.34.2, which is unfortunate. I am inclined to avoid that, though, if that error is the only thing that prevents a successful compilation.

comment:3 Changed 12 months ago by gk

After some searching I decided to use a newer Rust compiler (1.36.0) instead re-introducing our tor hack from earlier where we already used a more modern Rust version than 1.26.2 when compiling Rust code.

bug_32436_v4 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32436_v4&id=29b10882d320522938ed09f8989bec722fc92465) has a patch which allows me to build lucetc.

comment:4 Changed 11 months ago by gk

Keywords: GeorgKoppen201912 added; GeorgKoppen201911 removed

Moving my tickets to December.

comment:5 Changed 10 months ago by gk

Keywords: GeorgKoppen202001 added; GeorgKoppen201912 removed

No December anymore.

comment:6 Changed 10 months ago by gk

Keywords: TorBrowserTeam202001R added
Status: newneeds_review

comment:7 Changed 9 months ago by pili

Reviewer: boklm

comment:8 Changed 9 months ago by pili

Keywords: TorBrowserTeam202002R added; TorBrowserTeam202001R removed

Moving reviews to February

comment:9 Changed 8 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

The patch from branch gk/bug_32389_v5 looks good to me. I merged it to master as commit 37eb08fc9643749d4bfe602b6aca5dc1dcefcaf5.

Note: See TracTickets for help on using tickets.