Opened 11 months ago

Closed 7 months ago

#32437 closed task (fixed)

Include wasi-libc project into tor-browser-build

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security, GeorgKoppen202001, TorBrowserTeam202002R
Cc: Actual Points:
Parent ID: #32434 Points:
Reviewer: boklm Sponsor:

Description

For compiling things to wasm during the build process of tor-browser we need to have a sysroot. The wasi-libc project would provide that one. This ticket reflects Mozilla's https://bugzilla.mozilla.org/show_bug.cgi?id=1582192.

Child Tickets

Change History (7)

comment:1 Changed 10 months ago by gk

bug_32436_v4 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32436_v4&id=42e042558263732b5f3d6fc6d1c6b7b5c1c6a66c) has a patch for this bug included as it turns out lucetc needs a sysroot dir when running make install as we do.

comment:2 Changed 10 months ago by gk

Keywords: GeorgKoppen201912 added; GeorgKoppen201911 removed

Moving my tickets to December.

comment:3 Changed 9 months ago by gk

Keywords: GeorgKoppen202001 added; GeorgKoppen201912 removed

No December anymore.

comment:4 Changed 9 months ago by gk

Keywords: TorBrowserTeam202001R added
Status: newneeds_review

comment:5 Changed 8 months ago by pili

Reviewer: boklm

comment:6 Changed 8 months ago by pili

Keywords: TorBrowserTeam202002R added; TorBrowserTeam202001R removed

Moving reviews to February

comment:7 Changed 7 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

The patch in branch gk/bug_32389_v5 looks good to me. I merged it to master as commit e8574bbde076ba917f4d3fd3e71c6c7ee10716c4.

I also opened #33462 as I see we added one more place where we need a cc -> gcc symlink.

Note: See TracTickets for help on using tickets.