Opened 4 weeks ago

#32447 new defect

Refactor our initialization sequence into a logical order

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points: .5
Reviewer: Sponsor: Sponsor31-can

Description

There are several things I'd like out of a logical initialization sequence.

  1. I'd like nt_service_parse_options() to happen at immediately before our first call to config_parse_commandline().
  1. I'd like us to divide our initialization stages into separate function calls, divided based on how much of the commandline or config we have parsed up until then. The main "inflection points" in this process are calls to nt_service_parse_options(), config_parse_commandline(), and options_init_from_torrc().
  1. I'd like us to turn as much of our initialization into subsystems as possible.

Unfortunately, we do not have good unit tests for our NT services code, which makes reordering that troublesome.

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.