Use gorilla websocket instead of x/net websocket in proxy-go

See ticket:31028#comment:5

added component::circumvention/snowflake owner::arlolra priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
Owner: N/A to arlolra
Status: new to assigned

Here's a stab at this, https://github.com/keroserene/snowflake/commits/trac32465

I was able to bootstrap a client with it.

Trac:
Status: assigned to needs_review

Thanks arlo!

This looks good, and while I appreciate the refactor of CopyLoop into a common library, I fear that we will be undoing this with the changes in #29206 (moved) (see the most recent candidate). Not only are we encapsulating the web socket connection on the side inside a SnowflakeConn, we also handle the data received differently on the server side than the proxy side by using something similar to the ConnMap of Turbo Tunnel.

So for now I'd suggest keeping the shared library but hold off on moving the proxy function to it.

Trac:
Status: needs_review to needs_revision

So for now I'd suggest keeping the shared library but hold off on moving the proxy function to it.

Ok, I reverted that change in a second patch.

See, https://github.com/keroserene/snowflake/compare/trac32465

Trac:
Status: needs_revision to needs_review

Thanks! Looks good to me!

Trac:
Status: needs_review to merge_ready

Merged as, https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=30b5ef8a9e9c7a5b306e9285d1a8db323f8f22b2 https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=7092b2cb2c24759286f3ecc7713ad30115415e41

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/anti-censorship/pluggable-transports/snowflake#32465 (closed)