Opened 5 weeks ago

Closed 3 weeks ago

#32465 closed defect (fixed)

Use gorilla websocket instead of x/net websocket in proxy-go

Reported by: arlolra Owned by: arlolra
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords:
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Child Tickets

Change History (8)

comment:1 Changed 4 weeks ago by arlolra

Owner: set to arlolra
Status: newassigned

comment:2 Changed 3 weeks ago by arlolra

Status: assignedneeds_review

Here's a stab at this,
https://github.com/keroserene/snowflake/commits/trac32465

I was able to bootstrap a client with it.

comment:3 Changed 3 weeks ago by cohosh

Status: needs_reviewneeds_revision

Thanks arlo!

This looks good, and while I appreciate the refactor of CopyLoop into a common library, I fear that we will be undoing this with the changes in #29206 (see the most recent candidate). Not only are we encapsulating the web socket connection on the side inside a SnowflakeConn, we also handle the data received differently on the server side than the proxy side by using something similar to the ConnMap of Turbo Tunnel.

So for now I'd suggest keeping the shared library but hold off on moving the proxy function to it.

comment:4 Changed 3 weeks ago by arlolra

So for now I'd suggest keeping the shared library but hold off on moving the proxy function to it.

Ok, I reverted that change in a second patch.

See, https://github.com/keroserene/snowflake/compare/trac32465

comment:5 Changed 3 weeks ago by arlolra

Status: needs_revisionneeds_review

comment:6 Changed 3 weeks ago by cohosh

Status: needs_reviewmerge_ready

Thanks! Looks good to me!

comment:8 Changed 3 weeks ago by arlolra

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.