Opened 5 months ago

Closed 6 weeks ago

Last modified 3 weeks ago

#32493 closed task (fixed)

Consider adding MOZ_SERVICES_HEALTHREPORT to mozconfig

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam202002R, tbb-9.5a6, tbb-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Someone suggested on the blog that we unset MOZ_SERVICES_HEALTHREPORT in mozconfig:
https://blog.torproject.org/comment/285469#comment-285469

Apparently unsetting this would avoid including the file toolkit/components/telemetry/healthreport-prefs.js, which currently contains:

pref("datareporting.healthreport.infoURL", "https://www.mozilla.org/legal/privacy/firefox.html#health-report");
pref("datareporting.healthreport.uploadEnabled", true);

We already set datareporting.healthreport.uploadEnabled to false, so this wouldn't fix any issue, but would be defense in depth.

Child Tickets

Attachments (1)

0001-Bug-32493-Disable-MOZ_SERVICES_HEALTHREPORT.patch (804 bytes) - added by boklm 2 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 months ago by pili

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201911 removed

Moving tickets to December

comment:2 Changed 4 months ago by cypherpunks

ticket:31457#comment:9
The same is needed here:

-imply_option('MOZ_SERVICES_HEALTHREPORT', True)
+imply_option('MOZ_SERVICES_HEALTHREPORT', False)

comment:4 Changed 3 months ago by sysrqb

Keywords: TorBrowserTeam202001 added; TorBrowserTeam201912 removed

comment:5 in reply to:  3 ; Changed 2 months ago by boklm

Replying to cypherpunks:

https://searchfox.org/mozilla-esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#3116

So it seems disabling MOZ_SERVICES_HEALTHREPORT might allow us to disable MOZ_DATA_REPORTING too?

comment:6 Changed 2 months ago by boklm

Keywords: TorBrowserTeam202001R added; TorBrowserTeam202001 removed
Status: newneeds_review

I attached a patch to disable MOZ_SERVICES_HEALTHREPORT.

comment:7 Changed 8 weeks ago by pili

Keywords: TorBrowserTeam202002R added; TorBrowserTeam202001R removed

Moving reviews to February

comment:8 in reply to:  5 Changed 8 weeks ago by cypherpunks

Replying to boklm:

Replying to cypherpunks:

https://searchfox.org/mozilla-esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#3116

So it seems disabling MOZ_SERVICES_HEALTHREPORT might allow us to disable MOZ_DATA_REPORTING too?

Yes. LGTM.

comment:9 Changed 6 weeks ago by sysrqb

Status: needs_reviewneeds_revision

Thanks! I'd like this patch as a squash! on TB4: Tor Browser's Firefox preference overrides. (currently 4348eef9818fdbda51b9a89aa1cacc71c9770052). Can you update the patch or do you want me to update it?

comment:10 in reply to:  9 Changed 6 weeks ago by sysrqb

Keywords: tbb-9.5a6 added
Resolution: fixed
Status: needs_revisionclosed

Replying to sysrqb:

Thanks! I'd like this patch as a squash! on TB4: Tor Browser's Firefox preference overrides. (currently 4348eef9818fdbda51b9a89aa1cacc71c9770052). Can you update the patch or do you want me to update it?

Sorry, ingore that. This patch is good as-is. I applied as commit 6046d1d582804594a57d132280376b8027d1ed83 on tor-browser-68.5.0esr-9.5-1.

We already have a similar patch for Android.

comment:11 Changed 3 weeks ago by boklm

Keywords: tbb-backport added
Note: See TracTickets for help on using tickets.