#32499 closed defect (fixed)

Add a build step / documentation for code reuse in Cupcake

Reported by: arlolra Owned by: arlolra
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: snowflake-webextension
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: cohosh Sponsor:

Description


Child Tickets

Change History (8)

comment:1 Changed 11 months ago by arlolra

Owner: set to arlolra
Status: newassigned

comment:2 Changed 11 months ago by arlolra

Status: assignedneeds_review

comment:3 Changed 11 months ago by cohosh

Reviewer: cohosh

comment:4 Changed 11 months ago by cohosh

Status: needs_reviewmerge_ready

This looks great, thank you for working on this. I also appreciate the more detailed instructions and pulling the webextension information into the README.

When talking about initializing a new snowflake here, can we also encourage setting the proxy type field that's introduced in #31157? Here's an example of how it's set in init-webext.js: https://gitweb.torproject.org/pluggable-transports/snowflake.git/tree/proxy/init-webext.js#n175

It would be nice if they also let us know that they've worked it into their tool. We could add a sentence encouraging them to reach out to us.

comment:5 Changed 11 months ago by arlolra

Status: merge_readyassigned

comment:6 Changed 11 months ago by arlolra

Status: assignedneeds_review

I'll follow up with additional work here in a bit.

Here's a commit for that,
https://github.com/keroserene/snowflake/commit/1e45d48a3c4ef05434916d963f0c00d8c0246ac9

comment:7 Changed 11 months ago by cohosh

Status: needs_reviewmerge_ready

Looks good, thanks!

Note: See TracTickets for help on using tickets.