Opened 7 months ago

Closed 6 weeks ago

#32501 closed defect (fixed)

Add hasDormantCanceledByStartup to TOPL TorSettings Interface

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam202004R
Cc: gk, sysrqb Actual Points: .25
Parent ID: Points: .25
Reviewer: sysrqb Sponsor:

Description

hasDormantCanceledByStartup has been added to TorSettings in tor-android-service but not in TOPL. This breaks the build.

The reported issue
https://github.com/sisbell/tor-android-service/issues/17

Child Tickets

Change History (13)

comment:1 Changed 7 months ago by sisbell

Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: newneeds_revision

I added in the implementation for hasDormantCanceledByStartup. The value is false by default (but this is overridden to true in tor-android-service.

https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/2426b26c9f4563bc8459844ac82a9764cc3e46ae

comment:2 Changed 7 months ago by sisbell

Status: needs_revisionneeds_review

comment:3 Changed 6 months ago by sysrqb

Status: needs_reviewneeds_revision
+    @SettingsConfig
+    public TorConfigBuilder dormantCanceledByStartupFromSettings() {
+        if(settings.hasDormantCanceledByStartup()) {

nit: space

It seems like this will benefit from #32516, too.

comment:4 Changed 6 months ago by gk

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201911R removed

comment:5 Changed 6 months ago by sisbell

Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: needs_revisionneeds_review

comment:6 Changed 6 months ago by sisbell

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201911R removed

comment:7 Changed 6 months ago by pili

Reviewer: sysrqb

sysrqb to review

comment:8 Changed 6 months ago by sisbell

Actual Points: .25

comment:9 Changed 5 months ago by sysrqb

Keywords: TorBrowserTeam202001R added; TorBrowserTeam201912R removed

comment:10 Changed 4 months ago by pili

Keywords: TorBrowserTeam202002R added; TorBrowserTeam202001R removed

Moving reviews to February

comment:11 Changed 3 months ago by pili

Keywords: TorBrowserTeam202003R added; TorBrowserTeam202002R removed

We are no longer in February moving reviews

comment:12 Changed 2 months ago by pili

Keywords: TorBrowserTeam202004R added; TorBrowserTeam202003R removed

We are no longer in March

comment:13 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed by #33359.

Note: See TracTickets for help on using tickets.