Opened 4 weeks ago

Last modified 9 days ago

#32501 needs_review defect

Add hasDormantCanceledByStartup to TOPL TorSettings Interface

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201912R
Cc: gk, sysrqb Actual Points:
Parent ID: Points: .25
Reviewer: sysrqb Sponsor:

Description

hasDormantCanceledByStartup has been added to TorSettings in tor-android-service but not in TOPL. This breaks the build.

The reported issue
https://github.com/sisbell/tor-android-service/issues/17

Child Tickets

Change History (7)

comment:1 Changed 4 weeks ago by sisbell

Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: newneeds_revision

I added in the implementation for hasDormantCanceledByStartup. The value is false by default (but this is overridden to true in tor-android-service.

https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/2426b26c9f4563bc8459844ac82a9764cc3e46ae

comment:2 Changed 4 weeks ago by sisbell

Status: needs_revisionneeds_review

comment:3 Changed 2 weeks ago by sysrqb

Status: needs_reviewneeds_revision
+    @SettingsConfig
+    public TorConfigBuilder dormantCanceledByStartupFromSettings() {
+        if(settings.hasDormantCanceledByStartup()) {

nit: space

It seems like this will benefit from #32516, too.

comment:4 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201911R removed

comment:5 Changed 10 days ago by sisbell

Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: needs_revisionneeds_review

comment:6 Changed 10 days ago by sisbell

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201911R removed

comment:7 Changed 9 days ago by pili

Reviewer: sysrqb

sysrqb to review

Note: See TracTickets for help on using tickets.