Opened 2 months ago

Closed 2 months ago

#32508 closed defect (fixed)

opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

Reported by: boklm Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201911R
Cc: pospeselr Actual Points: 0.5
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

Someone reported this on the blog:
https://blog.torproject.org/comment/285516#comment-285516

Using the icon on the toolbar to change the security level is showing the "Privacy & Security" and "Tor" settings in the same pane, while they are in two different ones when opening them through the hamburger menu and selecting "Preferences".

I am not sure if it is a bug, or if it is intentional.

Child Tickets

Change History (7)

comment:1 Changed 2 months ago by gk

Cc: pospeselr added
Points: 0.5

That's a bug I think.

comment:2 Changed 2 months ago by pospeselr

Actual Points: 0.5
Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: newneeds_review

Needed to make all the immediate child elements in the tor preferences xul hidden by default. Pushed a fixup commit on the original 31286 patch.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32508

comment:3 Changed 2 months ago by gk

Hm, so the patch is not working for me. I still see the network settings on the security/privacy pane after applying your patch. Here is what I did:

1) Take a clean, new 9.5a2 Linux bundle (64bit) and extract it
2) Go tor tor-browser_$$/Browser/browser
3) unzip -d test omni.ja
4) cd test/chrome/browser/content/browser/torpreferences/
5) patch -p5 < /path/to/your/patch
6) cd ../../../../../
7) rm ../omni.ja
8) zip -r9 ../omni.ja *
9) cd ../
10) rm -rf test
11) start the so modified bundle for the first time and click on the shield icon so the security settings show up

Last edited 2 months ago by gk (previous) (diff)

comment:4 Changed 2 months ago by gk

Status: needs_reviewneeds_information

comment:5 Changed 2 months ago by pospeselr

Status: needs_informationneeds_review

gk: I speculated in IRC that you might have a startupCache issue:

(2019-11-18 11:38:44 AM) pospeselr: GeKo: I'm not sure why you're not seeing any change after applying the patch (regarding #32508 )
(2019-11-18 11:38:47 AM) zwiebelbot: (notice) tor#32508: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy - [needs_information] - https://bugs.torproject.org/32508
(2019-11-18 11:39:10 AM) pospeselr: perhaps you need to nuke your startcupCache ?
(2019-11-18 11:39:38 AM) pospeselr: doing a full build, and copying $out/dist/firefox/* over /Browser gives the right behavior
(2019-11-18 11:39:57 AM) pospeselr: I could do a full tor-browser-build to verify if you like

I did a nightly tor-browser-build using this patch just to be sure and the behaviour is as expected:

https://people.torproject.org/~richard/builds/bug_32508/tor-browser-linux64-tbb-nightly_en-US.tar.xz

comment:6 Changed 2 months ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: needs_reviewassigned

comment:7 in reply to:  5 Changed 2 months ago by gk

Resolution: fixed
Status: assignedclosed

Replying to pospeselr:

gk: I speculated in IRC that you might have a startupCache issue:

Actually, I don't think so see 1) in comment:3.

[snip]

https://people.torproject.org/~richard/builds/bug_32508/tor-browser-linux64-tbb-nightly_en-US.tar.xz

Thanks! I think the mistake I made was just patching torPane.xul (that is 5) in comment:3 is not enough). It seems when building then corresponding changes in preferences.xul got made which I overlooked by trying to take a shortcut.

We are good here, thanks! Cherry-picked your patch to tor-browser-68.2.0esr-9.5-1 (commit e847b87fda117ebf06459755b5dbd037eb1d349a).

Note: See TracTickets for help on using tickets.