Opened 2 months ago

Last modified 4 days ago

#32542 needs_review defect

hs-v3: Add the 2 missing SOCKS extended errors from prop304

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 043-can
Cc: brade, mcs Actual Points: 0.4
Parent ID: #14389 Points: 1
Reviewer: asn Sponsor: Sponsor27-must

Description

The two missing codes are the intro failure and RP failure.

    * X'F2' Onion Service Introduction Failed

      Client failed to introduce to the service meaning the descriptor was
      found but the service is not anymore at the introduction points. The
      service has likely changed its descriptor or is not running.

    * X'F3' Onion Service Rendezvous Failed

      Client failed to rendezvous with the service which means that the client
      is unable to finalize the connection.

Child Tickets

Change History (4)

comment:1 Changed 2 months ago by mcs

Cc: brade mcs added

comment:2 Changed 8 weeks ago by dgoulet

Discussion with asn on this:

  • We'll send back the X'F2' code if we get a NACK from every IP in the descriptor.
  • We'll send back the X'F3' code when the RP circuit _times out_. We'll need a spec clarification.
  • We'll send a *new* error code when all IP circuit timed out. Basically, if we try all IPs in the descriptor and they all gave us a circuit time out, we'll send back that code.

comment:3 Changed 6 weeks ago by dgoulet

Actual Points: 0.4
Status: assignedneeds_review

Branch: ticket32542_043_01
PR: https://github.com/torproject/tor/pull/1597

(No tor-spec patch since socks-extension.txt points to the man page for the error codes.)

This is a bit tricky as in the "from where we report the codes" so word of advise for the reviewer.

The introduction failure codes are reported back if the descriptor we just fetched has no usable introduction points. This is a bit counter intuitive but the reason is because tor will refetch a descriptor if all intro points fail and then notice they are the same again and stop. That very moment is where the failure is reported.

comment:4 Changed 4 days ago by nickm

Keywords: 043-can added

tag all currently needs_review tickets with 043-can. (Since there's code before the feature freeze, maybe we can take it.)

Note: See TracTickets for help on using tickets.