Allow ONION_CLIENT_AUTH_ADD credentials to be made permanent

The Permanent flag of ONION_CLIENT_AUTH_ADD is not implemented yet.

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #14389 (moved)

added 042-deferred-20190918 actualpoints::1.2 component::core tor/tor hs-auth milestone::Tor: 0.4.3.x-final network-team-roadmap-september parent::14389 points::2 priority::medium resolution::fixed reviewer::dgoulet severity::normal sponsor::27-must status::closed tbb-usability tor-hs type::defect ux-team labels

OK here we go:

little-t-tor branch: https://github.com/torproject/tor/pull/1563 torspec branch: https://github.com/torproject/torspec/pull/94

Some comments and changes from the original trajectory:

• Adding a Permanent credential requires the ClientOnionAuthDir torrc option to be set, and also the directory to be already created. When this is done, permanent credentials will be created as files within that directory.
• Nicknames have been completely ditched because of the huge PITA that it would be to add them to the non-forward-compatible client auth file format (as described by the corresponding commit messages both in torspec and tor). In the future we can consider adding them but that would be even more work. For now, this could be handled in the TB layer if needed.
• The REMOVE control port command will also remove the corresponding client auth files if they are permanent and they exist.

Trac:
Actualpoints: N/A to 1.2
Status: new to needs_review

Trac:
Reviewer: N/A to dgoulet

Good stuff. Minor things on the PR.

Trac:
Status: needs_review to needs_revision

Addressed issues! Please check again! :)

Trac:
Status: needs_revision to needs_review

Great! Merged!

(FYI, no changes file since this code hasn't been released yet. Was merged in master 2 weeks ago.)

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 16h

added 9h 36m of time spent

moved to tpo/core/tor#32562 (closed)