Use clang's -Wimplicit-fallthrough and fallthrough attribute on case statements

Trac:
Parent Ticket: #34078 (moved)

added code-correctness component::core tor/tor milestone::Tor: unspecified parent::34078 points::1 priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

Here's how we can check for that feature in clang: https://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-macros

I think the same syntax works on gcc, but we should check.

I believe we already enable that -- see configure.ac, and see "warning_flags" when building with clang.

Please reopen if I'm wrong.

Trac:
Resolution: N/A to worksforme
Status: new to closed

If we are doing it, we're doing it wrong, here's a fallthrough that should require the fallthrough attribute:

src/core/proto/proto_socks.c-      case SOCKS_RESULT_TRUNCATED:
src/core/proto/proto_socks.c-        if (datalen == n_pullup)
src/core/proto/proto_socks.c-          return 0;
src/core/proto/proto_socks.c-        /* FALLTHRU */
src/core/proto/proto_socks.c-      case SOCKS_RESULT_MORE_EXPECTED:
src/core/proto/proto_socks.c-        res = 0;
src/core/proto/proto_socks.c-        break;

I don't think comments count, and even if they do, I can't imagine this spelling being supported :-)

Trac:
Resolution: worksforme to N/A
Status: closed to reopened

Here's a working reference: https://releases.llvm.org/9.0.0/tools/clang/docs/AttributeReference.html#fallthrough

Use clang's -Wimplicit-fallthrough and fallthrough attribute on case statements

Child items ...

Activity