Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#32581 closed enhancement (worksforme)

Turn on clang's -Wtype-safety to detect fnctl() and ioctl() errors

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: code-correctness
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Child Tickets

Change History (3)

comment:1 Changed 3 months ago by nickm

We have this already in our list of warnings that we enable if they are present:

     -Wtentative-definition-incomplete-type
     -Wtrampolines
     -Wtype-safety
     -Wtypedef-redefinition

When I build with clang, it's in my warning_flags file:

...-Wtentative-definition-incomplete-type -Wtype-safety -Wtypedef-redefinition -Wtypename-missing...

I think we already do this?

comment:2 Changed 3 months ago by nickm

Resolution: worksforme
Status: newclosed

Please reopen if I am wrong here

comment:3 Changed 3 months ago by teor

I looked for it, but I must have been looking in the wrong file.

Note: See TracTickets for help on using tickets.