Add macro spacing checks to "make check-spaces"

Let's check macro spacing like we check other keyword spacing.

And let's check for else {.

changed milestone to %Tor: unspecified

Trac:
Parent Ticket: #32522 (moved)

added 043-deferred actualpoints::0.4 component::core tor/tor milestone::Tor: unspecified owner::teor parent::32522 points::0.2 priority::medium resolution::wontfix reviewer::nickm severity::normal status::closed type::enhancement labels

See my PR:

• master: https://github.com/torproject/tor/pull/1566

I ended up implementing:

• check else {
• check all the preprocessor directives we currently use
• check for no spaces and multiple spaces (in cases where that makes sense)

Trac:
Status: assigned to needs_review

Trac:
Actualpoints: 0.2 to 0.4

I need to revise this patch to check win32/orconfig.h in more places. (I think at least coccinelle.)

Trac:
Status: needs_review to needs_revision

(Before we spend too much time on this, let's also make sure it's something that our code autoformatter won't take care of for us, so that the effort isn't redundant)

I fixed the patch so all 4 lists of Tor C files are consistent.

Replying to nickm:

(Before we spend too much time on this, let's also make sure it's something that our code autoformatter won't take care of for us, so that the effort isn't redundant)

I think we're still some time away from automated C formatting. We should trial make autostyle first, see #31713 (moved). I think I finally fixed the last few instances of #31891 (moved) on Monday.

I discovered these issues during #32522 (moved), I don't expect to spend any more time on check-spaces. It is an improvement, and it shouldn't take much time to review.

I suggest we merge now, and then remove redundant (or conflicting) parts of check-spaces when we implement C autoformatting?

Trac:
Status: needs_revision to needs_review

Possibly conflicting with #32613 (moved).

The code looks plausible, but let's merge this after #32613 (moved), so we can add tests for the new failure cases here.

Trac:
Status: needs_review to needs_revision

Sponsor 31 is over, this isn't a roadmap task any more.

Trac:
Keywords: network-team-roadmap-november deleted, N/A added

I split the comments out of the final commit and pushed them to master. (They're unrelated to the rest of this branch.)

So we'll need to deal with a merge conflict, if we ever push these changes.

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

Trac:
Keywords: N/A deleted, 043-deferred added

Trac:
Milestone: Tor: 0.4.3.x-final to Tor: unspecified

No more sponsor 31. All this tickets remained open after sponsor 31 ended.

Trac:
Sponsor: Sponsor31-can to N/A

Probably obsoleted by the C autostyle changes.

Trac:
Status: needs_revision to closed
Resolution: N/A to wontfix

closed

changed time estimate to 1h 36m

added 3h 12m of time spent

mentioned in issue #32613 (moved)

mentioned in issue #32613 (moved)

mentioned in issue #32522 (moved)

moved to tpo/core/tor#32610 (closed)