Opened 8 years ago

Closed 3 years ago

#3262 closed defect (wontfix)

Weather should look for "-alpha" dev versions, too, when checking recommended Tor versions

Reported by: kaner Owned by: kaner
Priority: Medium Milestone:
Component: Metrics/Tor Weather Version:
Severity: Keywords: version checking
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently, Weather only looks for "-dev" in a Tor version string to determine if an "ok" development version of Tor is ran by a node. We should tolerate recent "-alpha" versions, too, because people running those shouldn't be bothered by Weather with "version not recommended" emails.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by karsten

Parsing the version string for "-alpha" or "-dev" seems fragile, especially since we added a "-beta" recently. Who knows what we're going to add in the future.

Maybe we can compare the number part of the version string to decide whether a version is a) included in the recommended versions, b) newer than all recommended versions of a major version, c) older than all recommended versions, or d) otherwise not included. Here's an example (not the current recommended versions):

client-versions 0.2.1.29,0.2.1.30,0.2.2.21-alpha,0.2.2.22-alpha,0.2.2.25-alpha,0.2.2.26-beta,0.2.2.27-beta,0.2.3.1-alpha

In case a), everything's good. Case b) could be 0.2.2.28-something or 0.2.3.2-alpha and is likely due to us not recommending a new version yet. Examples for c) and d) are 0.2.1.28 and 0.2.2.23-alpha, respectively, and indicate an outdated version. We should probably inform the user in cases c) and d).

comment:2 Changed 6 years ago by keb

Keywords: version checking added

This bug seems to be about Tor Weather not detecting the running version correctly, so i am reporting here.
I just got an email but my node is running the newest version 0.2.4.8-alpha:
"It appears that the Tor node Pasquino (id: D3ED 9111 83DF 31FD B744 A22F 94BE 6A85 6AC7 7D12) you've been observing is running an obsolete version of Tor."

ticket:2625 and ticket:6952 might help relay operators receiving the message be less confused by the incorrect diagnosis.

comment:3 Changed 3 years ago by karsten

Resolution: wontfix
Status: newclosed

Tor Weather has been discontinued as of May 24, 2016: https://lists.torproject.org/pipermail/tor-relays/2016-June/009424.html. Batch-closing all remaining tickets as announced in #19382. A list of these tickets and any other Weather tickets modified after June 26, 2016 will be available here: https://trac.torproject.org/projects/tor/query?changetime=Jun+27%2C+2016..&component=^Metrics%2FTor+Weather

Note: See TracTickets for help on using tickets.