Opened 11 months ago

Last modified 4 months ago

#32622 assigned defect

Fix misleading STATUS_CLIENT warning message

Reported by: phw Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: anticensorship-wants, 043-should, 044-should, postfreeze-ok
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After Tor 0.4.3.0-alpha-dev successfully established a TCP connection with a bridge but failed to finish its handshake, it sends the following STATUS_CLIENT message to the controller:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir SUMMARY="Finishing handshake with directory server" WARNING="DONE" REASON=DONE COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

One can reproduce this by using torproject.org's web server as a bridge: 95.216.163.36:80. The substring WARNING="DONE" is misleading and should – if I'm interpreting control-spec.txt correctly – contain a human-readable description of what went wrong. Other STATUS_CLIENT messages do a better job; for example:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=5 TAG=conn_dir SUMMARY="Connecting to directory server" WARNING="Connection refused" REASON=CONNECTREFUSED COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

Here, the substring WARNING="Connection refused" gives me a good idea of what's going on.

I suggest to fix the warning in this particular error case.

Child Tickets

Change History (15)

comment:1 Changed 11 months ago by nickm

Milestone: Tor: 0.4.3.x-final

comment:2 Changed 10 months ago by nickm

Keywords: fast-fix anticensorship-wants added

comment:3 Changed 10 months ago by nickm

Keywords: 043-should added

comment:4 Changed 9 months ago by nickm

Owner: set to catalyst
Status: newassigned

comment:5 in reply to:  description Changed 8 months ago by catalyst

Replying to phw:

After Tor 0.4.3.0-alpha-dev successfully established a TCP connection with a bridge but failed to finish its handshake, it sends the following STATUS_CLIENT message to the controller:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir SUMMARY="Finishing handshake with directory server" WARNING="DONE" REASON=DONE COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

Thanks. Could you please clarify if you saw more useful behavior in a previous release? If so, which? Trying to figure out if this is a regression, or if it's a bug that's been around for a while.

comment:6 in reply to:  description ; Changed 8 months ago by catalyst

Replying to phw:

After Tor 0.4.3.0-alpha-dev successfully established a TCP connection with a bridge but failed to finish its handshake, it sends the following STATUS_CLIENT message to the controller:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir SUMMARY="Finishing handshake with directory server" WARNING="DONE" REASON=DONE COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

Also, could you please confirm the affected tor versions? I'm pretty sure the handshake_dir and conn_dir tags predate the bootstrap phase rename in 0.4.0 and no longer exist after that.

I do see a similar problem on master, though, so it's worth further investigation in any case.

comment:7 Changed 8 months ago by catalyst

Also confirmed that this happens on 0.3.5, so it's been around a while. So not a regression in 0.4.3.

comment:8 in reply to:  6 Changed 8 months ago by phw

Replying to catalyst:

Replying to phw:

After Tor 0.4.3.0-alpha-dev successfully established a TCP connection with a bridge but failed to finish its handshake, it sends the following STATUS_CLIENT message to the controller:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir SUMMARY="Finishing handshake with directory server" WARNING="DONE" REASON=DONE COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

Also, could you please confirm the affected tor versions? I'm pretty sure the handshake_dir and conn_dir tags predate the bootstrap phase rename in 0.4.0 and no longer exist after that.

I do see a similar problem on master, though, so it's worth further investigation in any case.


I can confirm that I'm seeing this with 0.4.3.0-alpha-dev. I just checked out master (currently 0.4.4.0-alpha-dev) and I'm seeing the same issue.

comment:9 Changed 8 months ago by catalyst

Keywords: fast-fix removed

Deleting "fast-fix" because the it's not very obvious to me how this is going wrong. Anyone else have suggestions?

comment:10 Changed 5 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

0.4.3 was released: Move non merge-ready 0.4.3 tickets to 044.

comment:11 Changed 5 months ago by nickm

Keywords: 044-should added

Add 044-should to all foo-wants tickets in 044

comment:12 Changed 5 months ago by nickm

Keywords: postfreeze-ok added

Mark tickets which are important or safe enough to look at post-freeze for 0.4.4.

comment:13 Changed 5 months ago by nickm

Owner: catalyst deleted

Un-assign tickets.

comment:14 Changed 5 months ago by nickm

Status: assignednew

comment:15 Changed 4 months ago by nickm

Owner: set to nickm
Status: newassigned
Note: See TracTickets for help on using tickets.