#32629 closed task (fixed)

Re-enable 1 or 2 more macOS jobs in Travis

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: consider-backport-immediately, tor-ci, ipv6, macos, 029-backport, 035-backport, 040-backport, 041-backport, 042-backport
Cc: Actual Points: 0.3
Parent ID: Points: 0.5
Reviewer: catalyst Sponsor:

Description

Reverts #32177.

We might need to merge or disable some jobs, to get builds to finish fast enough.

Child Tickets

Change History (13)

comment:1 Changed 11 months ago by teor

Actual Points: 0.2
Points: 0.20.5
Status: assignedneeds_revision

I have some draft ticket32629_* branches, but I need to check that they pass CI, and check now much extra time they cost us.

If we have to disable any jobs, it should be the Rust job, because that's lower priority than chutney IPv6.

comment:2 Changed 11 months ago by teor

Actual Points: 0.20.3
Keywords: consider-backport-immediately ipv6 macos 029-backport 035-backport 040-backport 041-backport 042-backport added
Status: needs_revisionneeds_review

I re-enabled the macOS chutney job, but not the macOS Rust job. (macOS is slow, and Rust is the lowest priority.)

Here are my PRs:

Test branches:

Last edited 11 months ago by teor (previous) (diff)

comment:3 Changed 11 months ago by teor

(Some test branches appear to fail in the GitHub list, but that's just due to spurious coverage reductions.)

comment:4 Changed 11 months ago by asn

Reviewer: catalyst

comment:5 in reply to:  2 ; Changed 11 months ago by catalyst

Status: needs_reviewneeds_information

Replying to teor:

I re-enabled the macOS chutney job, but not the macOS Rust job. (macOS is slow, and Rust is the lowest priority.)

Here are my PRs:

Test branches:

Thanks! Mostly looks good. I did notice that the macOS chutney job is significantly slow, about 20 minutes? I'm not sure it significantly adds to the total run time except maybe on 0.2.9.

Also, do we need a changes file? Some of the upcoming releases might ship with #32177.

comment:6 in reply to:  5 Changed 11 months ago by teor

Replying to catalyst:

Replying to teor:

I re-enabled the macOS chutney job, but not the macOS Rust job. (macOS is slow, and Rust is the lowest priority.)

Here are my PRs:

Test branches:

Thanks! Mostly looks good. I did notice that the macOS chutney job is significantly slow, about 20 minutes? I'm not sure it significantly adds to the total run time except maybe on 0.2.9.

Yes, it's slow. It does add to the total run time, but the job can finish successfully without it - that's why it's in allow_failure/fast_finish.

Also, do we need a changes file? Some of the upcoming releases might ship with #32177.

The revert deletes the changes file, but you're right, we should replace it with another one. I'll do that now.

comment:7 Changed 11 months ago by teor

Status: needs_informationneeds_review

I deleted and replaced the #32177 changes file in 0.2.9 and 0.3.5, because it hadn't been released yet. I added a different changes file to 0.4.2.

comment:8 Changed 11 months ago by teor

Status: needs_reviewneeds_revision

I didn't realise the releases were already out. I'll revert these changes, and just use the post-release changes file for each one.

comment:9 Changed 11 months ago by teor

Status: needs_revisionneeds_review

Ok, now it's fixed with a post-release changes file for each branch.

comment:10 in reply to:  9 Changed 11 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to teor:

Ok, now it's fixed with a post-release changes file for each branch.

Thanks! Looks good. Feel free to merge after CI passes.

comment:11 Changed 11 months ago by teor

I'm going to wait until the pending releases are out, then merge,

comment:12 Changed 10 months ago by nickm

Pending releases are out; feel free to merge at your convenience.

comment:13 Changed 10 months ago by teor

Milestone: Tor: 0.4.3.x-finalTor: 0.2.9.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.2.9 and later.

Merged with #30984.

Note: See TracTickets for help on using tickets.