Opened 13 days ago

Last modified 27 hours ago

#32639 needs_review defect

cancel_descriptor_fetches() uses wrong connection list function

Reported by: asn Owned by: neel
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs newnym backport?
Cc: gaba, neel Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor: Sponsor27-can

Description

cancel_descriptor_fetches() does:

  smartlist_t *conns =
    connection_list_by_type_state(CONN_TYPE_DIR, DIR_PURPOSE_FETCH_HSDESC);

when it should be using connection_list_by_type_purpose().

Child Tickets

Change History (9)

comment:1 Changed 11 days ago by nickm

Keywords: backport? added

comment:2 Changed 6 days ago by neel

Owner: set to neel
Status: newassigned

comment:4 Changed 6 days ago by neel

Status: assignedneeds_review

comment:5 Changed 6 days ago by teor

Status: needs_reviewneeds_revision

The commit message for this ticket is wrong, it says cancel_descriptor_fetches() twice.

comment:6 Changed 6 days ago by neel

Status: needs_revisionneeds_review

Fixed it. Did a force push as there were no comments on the branch.

comment:7 Changed 2 days ago by asn

Reviewer: asn

comment:8 Changed 28 hours ago by asn

Status: needs_reviewneeds_revision

The changes file has the same issue tho.

comment:9 Changed 27 hours ago by neel

Status: needs_revisionneeds_review

Fixed it.

Note: See TracTickets for help on using tickets.