Opened 10 months ago

Last modified 10 months ago

#32654 new defect

Torbrowser overides user disabling tor proxy after restart

Reported by: woyazi Owned by: brade
Priority: Low Milestone:
Component: Applications/Tor Launcher Version:
Severity: Minor Keywords: TorBrowserTeamTriaged
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

extensions.torlauncher.start_tor false, network.proxy.type 0, and network.proxy.socks_remote_dns false allow a user to disable the tor proxy and still use the security and privacy benefits of the tor browser.
However, after restarting the browser, network.proxy.type resets to 1 and network.proxy.socks_remote_dns resets to true.

Tor Browser version: 9.0.1

Child Tickets

Change History (4)

comment:1 Changed 10 months ago by pili

Keywords: TorBrowserTeamTriaged added

I'm able to reproduce this, the question is whether we want to allow this behavior

comment:2 Changed 10 months ago by gk

Version: Tor: unspecified

We don't use the version field (in particular not with some Tor version).

comment:3 Changed 10 months ago by gk

I actually think this ticket has the same underlying issue as #32654 (it it is an issue at all) in that anything else than a manual proxy does not seem to work anymore. Without looking at the code, though, nothing comes to mind what we could have changed.

Version 0, edited 10 months ago by gk (next)

comment:4 in reply to:  3 Changed 10 months ago by mcs

Replying to gk:

I actually think this ticket has the same underlying issue as #32224 (it it is an issue at all) in that anything else than a manual proxy does not seem to work anymore. Without looking at the code, though, nothing comes to mind what we could have changed.

I think the difference with Tor Browser 9 compared to earlier versions is that people cannot disable the (now built-in) Tor Launcher extension. With Tor Launcher disabled, Torbutton did not pick up proxy settings from Tor Launcher and — as long as no environment variables were set — did not make any pref changes (see setProxySettings() inside components/startup-observer.js).

A workaround is to set the TOR_TRANSPROXY environment variable, although that forces the settings as follows:

this._prefs.setBoolPref("network.proxy.socks_remote_dns", false);
this._prefs.setIntPref("network.proxy.type", 0);
this._prefs.setIntPref("network.proxy.socks_port", 0);
this._prefs.setCharPref("network.proxy.socks", "");
Note: See TracTickets for help on using tickets.