#32663 closed defect (fixed)

Require coccinelle 1.0.4 in check_cocci_parse.sh

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 043-must, tor-test
Cc: catalyst, nickm Actual Points: 0.3
Parent ID: Points: 0.5
Reviewer: ahf Sponsor: Sponsor31-can

Description (last modified by teor)

In #31919, we upgraded most of our CI jobs to Ubuntu bionic, so that we had a recent enough version of coccinelle (1.0.4 or later).

But we didn't put a minimum coccinelle version requirement in check_cocci_parse.sh.

We should also check what happens if we install coccinelle on Windows.

For details, see:

Child Tickets

Change History (8)

comment:1 Changed 11 months ago by teor

Description: modified (diff)

comment:2 Changed 11 months ago by teor

Actual Points: 0.2
Status: assignedneeds_review

See my PR:

No changes file required, this is a bug in master.

coccinelle isn't available in mingw, msys2, or chocolatey, so it's unlikely anyone will be running it on Windows. And if they do, it should just work :-)

comment:3 Changed 11 months ago by ahf

Reviewer: ahf
Status: needs_reviewmerge_ready

Looks good to me.

comment:4 Changed 11 months ago by teor

Actual Points: 0.20.3
Status: merge_readyneeds_review

My test failed, because the version regular expression was too strict:

Here's an updated branch with fixups:

Here is the skipped test with an old coccinelle:

Here's the squashed version to merge:

comment:5 Changed 11 months ago by teor

Here's the output when the test is skipped:

comment:6 Changed 11 months ago by catalyst

Cc: catalyst added

comment:7 Changed 11 months ago by ahf

Status: needs_reviewmerge_ready

Ah, good catch.

The new branch looks fine, too, and very good we print the version during execution.

comment:8 Changed 11 months ago by teor

Cc: nickm added
Resolution: fixed
Status: merge_readyclosed

Merged to master, maybe this change will fix some CI issues that nickm has been seeing?
(I'm not sure, but it is possible.)

Note: See TracTickets for help on using tickets.