Opened 8 months ago

Closed 7 months ago

#32665 closed enhancement (fixed)

Parse newly added Snowflake statistics lines

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: metrics-team, cohosh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

As cohosh writes in #31157, Snowflake statistics files will soon contain new lines:

diff --git a/doc/broker-spec.txt b/doc/broker-spec.txt
index 2877784..eba3347 100644
--- a/doc/broker-spec.txt
+++ b/doc/broker-spec.txt
@@ -31,6 +31,24 @@ Metrics data from the Snowflake broker can be retrieved by sending an HTTP GET r
         A count of the total number of unique IP addresses of Snowflake
         proxies that have polled.
 
+    "snowflake-ips-standalone" NUM NL
+        [At most once.]
+
+        A count of the total number of unique IP addresses of snowflake
+        proxies of type "standalone" that have polled.
+
+    "snowflake-ips-badge" NUM NL
+        [At most once.]
+
+        A count of the total number of unique IP addresses of snowflake
+        proxies of type "badge" that have polled.
+
+    "snowflake-ips-webext" NUM NL
+        [At most once.]
+
+        A count of the total number of unique IP addresses of snowflake
+        proxies of type "webext" that have polled.
+
     "snowflake-idle-count" NUM NL
         [At most once.]

Let's parse these new lines in metrics-lib as soon as files containing them exist on CollecTor.

Child Tickets

Change History (3)

comment:1 Changed 8 months ago by karsten

Status: newneeds_review

comment:2 Changed 7 months ago by irl

Status: needs_reviewmerge_ready

lgtm

comment:3 Changed 7 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for looking! Merged to master. Closing.

Note: See TracTickets for help on using tickets.