Opened 8 months ago

Closed 8 months ago

#32686 closed enhancement (user disappeared)

Show TOR Dns port status from controller

Reported by: bounteous17 Owned by: atagar
Priority: Medium Milestone:
Component: Archived/Nyx Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by atagar

Status: newneeds_revision

Hi bounteous17, did you try running this without a DNS listener? It looks like you default the value to None, but then present it unless it's zero.

comment:2 in reply to:  1 Changed 8 months ago by bounteous17

Replying to atagar:

Hi bounteous17, did you try running this without a DNS listener? It looks like you default the value to None, but then present it unless it's zero.

I wanted to follow the same logic as the control_port. It is true that if None is shown, it can be understood that it is a non-optional parameter and that it is not configured.

I will modify it so that the 'DNS Port' is not displayed if it is not configured.

comment:3 Changed 8 months ago by atagar

I wanted to follow the same logic as the control_port.

Gotcha. That is correct (control_port is the logic to pattern this after), but that checked for None rather than zero...

  if vals.control_port:
    if width >= x + 19 + len(vals.control_port) + len(vals.auth_type):
      auth_color = RED if vals.auth_type == 'open' else GREEN

comment:4 Changed 8 months ago by atagar

Resolution: user disappeared
Status: needs_revisionclosed

Hi bounteous17, resolving this. I'm moving issues to GitHub so if you revise this please reopen at https://github.com/torproject/nyx/issues

Note: See TracTickets for help on using tickets.