Opened 11 months ago

Closed 9 months ago

#32700 closed defect (fixed)

No need to disable GeckoDriver in Windows mozconfig files

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202001R, GeorgKoppen201912
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: boklm Sponsor:

Description

We compile with --disable-tests on Windows which automatically disables GeckoDriver. Thus, we can clean up our mozconfig files a bit.

Child Tickets

Change History (8)

comment:1 Changed 11 months ago by gk

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201912 removed
Status: newneeds_review

comment:2 Changed 11 months ago by cypherpunks

Child of #4280.

ac_add_options --enable-default-toolkit=cairo-windows is not needed too.

mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" - Mozilla and TBA don't set it that way, and you should not.

A new line is needed after ac_add_options --disable-eme, because of the comment above it.

# Disable telemetry-># Disable telemetry reporting. # Disable telemetry is #32493.

comment:3 Changed 10 months ago by sysrqb

Keywords: TorBrowserTeam202001R added; TorBrowserTeam201912R removed

comment:4 Changed 10 months ago by gk

Keywords: GeorgKoppen202001 added; GeorgKoppen201912 removed

No December anymore.

comment:5 Changed 10 months ago by gk

Keywords: GeorgKoppen201912 added; GeorgKoppen202001 removed

comment:6 Changed 9 months ago by boklm

Reviewer: boklm

comment:7 in reply to:  2 Changed 9 months ago by boklm

Replying to cypherpunks:

Child of #4280.

ac_add_options --enable-default-toolkit=cairo-windows is not needed too.

mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" - Mozilla and TBA don't set it that way, and you should not.

Please open separate tickets for those issues.

comment:8 in reply to:  1 Changed 9 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

bug_32700 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32700&id=40502c9d0abb4e2c6b732162536fd2ea26bfe35b) has the patch for review.

This looks good to me. I merged the patch to master with commit b1690c3404c0454cb805a01e94e7d45e74ad17e0.

Note: See TracTickets for help on using tickets.