#32704 closed defect (fixed)

Port changelog tools to python 3

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: Sponsor:

Description

I use sortChanges.py and format_changelog.py to prepare changelogs. These scripts don't use use the python3 list syntax. I should port them.

Child Tickets

Change History (5)

comment:1 Changed 11 months ago by nickm

Actual Points: 0
Owner: set to nickm
Status: newaccepted

Branch is ticket32704 with PR at https://github.com/nmathewson/tor/pull/new/ticket32704 .

I've tested these changes by using them with python2 and python3 to regenerate the changelogs for the current pending releases. The output looks correct.

comment:2 Changed 11 months ago by nickm

Status: acceptedneeds_review

comment:3 Changed 11 months ago by ahf

Status: needs_reviewmerge_ready

Looks fine, but it's not a PR in the link, so I could not check CI, but it looks like a minor change that doesn't impact any of the CI checks?

comment:4 Changed 11 months ago by nickm

oops, PR is https://github.com/torproject/tor/pull/1589 . Going to let CI pass before merging.

comment:5 Changed 11 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

CI passed; merging.

Note: See TracTickets for help on using tickets.