Opened 11 months ago

Closed 9 months ago

#32706 closed defect (fixed)

Tried to establish rendezvous on non-edge circuit

Reported by: computer_freak Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version: Tor: 0.4.1.6
Severity: Normal Keywords: tor-log, tor-relay, tor-hs, 043-should, BugSmashFund
Cc: Actual Points:
Parent ID: #15618 Points: 0.1
Reviewer: asn Sponsor:

Description

In #12997comment:6 nickm requested to open a new ticket if someone gets that warning again.

I get that warning since weeks on 0.4.1.6 about once a day on different relays.
Even if #12997 is implemented i never saw a more specific warning than that simple line.

This is all the log shows me:

Dec 09 10:36:03.000 [notice] DoS mitigation since startup: 10 circuits killed with too many cells. 1835037 circuits rejected, 91 marked addresses. 711976 connections closed. 10660 single hop clients refused.
Dec 09 12:29:48.000 [warn] Tried to establish rendezvous on non-edge circuit
Dec 09 16:36:03.000 [notice] Heartbeat: Tor's uptime is 47 days 0:00 hours, with 23309 circuits open. I've sent 56816.96 GB and received 56583.09 GB.

Child Tickets

Change History (12)

comment:1 Changed 11 months ago by computer_freak

I just see that the ticket #12997 is not exactly the same error message than the one i get.
Seems Google trapped me into it:)
So if possible please rename this ticket.

Anyway i get the error message i provided and dont know what to do with it.

comment:2 Changed 10 months ago by arma

Resolution: duplicate
Status: newclosed

Thanks! I am going to close this one in favor of #15618. And I've left a note on #12297 for the next person who gets caught in your Google trap. :)

comment:3 Changed 10 months ago by teor

Keywords: tor-log tor-relay tor-hs 043-should BugSmashFund added
Milestone: Tor: 0.4.3.x-final
Points: 0.1
Resolution: duplicate
Status: closedreopened
Version: Tor: 0.4.1.6

It's not actually a duplicate, so we should do the same thing we did in #15618, and turn this warning into a protocol warning.

Since these seem to be recurring issues in other people's code, I suggest we make all these warnings protocol warnings:

  • Tried to establish rendezvous on non-edge circuit
  • Duplicate rendezvous cookie in ESTABLISH_RENDEZVOUS
  • Impossibly short INTRODUCE1 cell on circuit
  • Incorrect signature on ESTABLISH_INTRO cell
  • Couldn't decode public key

comment:4 Changed 10 months ago by teor

Parent ID: #15618
Summary: Tried to establish rendezvous on non-OR or non-edge circuitTried to establish rendezvous on non-edge circuit

comment:5 Changed 10 months ago by arma

Oops! Good catch.

Yes, I think turning those into protocol-warns is a good direction to go. (I haven't looked at each of them to be convinced that each of them should change, but I expect and hope that we find they should.)

comment:6 Changed 10 months ago by fingau

I have just noticed the same [warn] thirty-six (36) times on eleven (11) of my sixteen (16) relays. The first one, and the most recent one, being:-

Dec 07 03:49:28.000 [warn] Tried to establish rendezvous on non-edge circuit
Dec 12 10:23:33.000 [warn] Tried to establish rendezvous on non-edge circuit

All of my relays are the same, namely "Ubuntu 18.04.3 LTS bionic" and Tor version "0.4.1.6". They are spread across ten internet providers and seven countries.

comment:7 Changed 10 months ago by neel

Cc: neel added
Owner: set to neel
Status: reopenedassigned

comment:8 Changed 10 months ago by neel

Owner: neel deleted

comment:9 Changed 10 months ago by neel

Cc: neel removed
Status: assignednew

comment:10 Changed 9 months ago by ahf

Owner: set to dgoulet
Status: newassigned

comment:11 Changed 9 months ago by dgoulet

Reviewer: asn
Status: assignedneeds_review

I've turned a number of log statement to protocol warning within rendmid.c. I believe all of them can be triggered remotely so no need to warn or info if they happen.

Branch: ticket32706_043_01
PR: https://github.com/torproject/tor/pull/1700

comment:12 Changed 9 months ago by asn

Resolution: fixed
Status: needs_reviewclosed

LGTM! Merged!

Note: See TracTickets for help on using tickets.