Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3271 closed defect (implemented)

obfsproxy needs unit tests

Reported by: asn Owned by: asn
Priority: Medium Milestone:
Component: Archived/Obfsproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


obfsproxy has most unit tests it currently needs in src/test/ but there are some missing.
I dug into some ancient IRC logs of mine and according to them we miss:
"SOCKS4, IPv6 and probably handle_socks() and socks_state_get_address() unit tests."

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by asn

Status: newneeds_review

SOCKS4 and IPv6 unit tests can be found in my bug3271 obfsproxy branch.

handle_socks() and socks_state_set_address() unit tests won't be done, because it doesn't really make sense and my past self is stupid.

comment:2 Changed 9 years ago by nickm

Tests look fine; merged.

comment:3 Changed 9 years ago by nickm

(Does that leave more stuff to do?)

comment:4 in reply to:  3 Changed 9 years ago by asn

Resolution: implemented
Status: needs_reviewclosed

Replying to nickm:

(Does that leave more stuff to do?)

I can't see anything else, at the moment.
I'll close this and re-open it if something happens.

comment:5 Changed 9 years ago by arma

Component: Pluggable transportObfsproxy
Note: See TracTickets for help on using tickets.