Allow chutney users to disable tor's sandbox at runtime

In #32240 (moved), we discovered that tor's sandbox doesn't work on recent Ubuntu versions. So we need to disable the sandbox on those CI jobs.

One good way to implement this change, is by making it a first-class chutney feature.

Trac:
Parent Ticket: #32240 (moved)

added BugSmashFund actualpoints::0.3 chutney component::core tor/chutney owner::teor parent::32240 points::1 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed tor-ci type::enhancement labels

Trac:
Component: Core Tor/Tor to Core Tor/Chutney

See my PR:

• chutney master: https://github.com/torproject/chutney/pull/40

Details:

• Set the default for Sandbox based on the platform: 1 for Linux, 0 for everything else.
• Allow the user to override it with --sandbox or CHUTNEY_TOR_SANDBOX.

Assigning nickm as the reviewer, because he's familiar with the details.

Trac:
Actualpoints: N/A to 0.2
Reviewer: N/A to nickm
Status: assigned to needs_review

Marking as BugSmashFund, because this change is part of fixing the user-visible bug #32722 (moved).

Trac:
Keywords: N/A deleted, BugSmashFund added

This looks reasonable to me.

I would maybe suggest considering having it so that the ${sandbox} variable is only 0 or 1, and the torrc includes "Sandbox ${sandbox}". But I'm okay with this design too if you prefer it.

Trac:
Status: needs_review to merge_ready

Yes, I think that works in this case. For some other variables, we comment out the whole line to use tor's compiled-in default. But we don't need that feature here.

That makes for a much nicer implementation:

• define getenv_bool()
• add sandbox to the DEFAULTS dict

Trac:
Status: merge_ready to needs_revision

I added a fixup to the PR with the getenv_bool()/DEFAULTS/Sandbox ${sandbox} implementation.

Trac:
Actualpoints: 0.2 to 0.3
Status: needs_revision to needs_review

LGTM!

Trac:
Status: needs_review to merge_ready

Squashed and merged to master with #32731 (moved).

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 8h

added 2h 24m of time spent

mentioned in issue #32731 (moved)

mentioned in issue #32240 (moved)

moved to tpo/core/chutney#32721 (closed)