Opened 8 months ago

Closed 5 months ago

#32737 closed defect (fixed)

Please remove wrongly pushed branches from the tor-browser repo

Reported by: gk Owned by: irl
Priority: Medium Milestone:
Component: Internal Services/Service - git Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

tor-browser should only contain branches that contain our patches on top of the respective Firefox ESR code. Thus, please remove the following branches that got erroneously pushed:

bug_28622
esr24
esr31
master

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by irl

Status: newneeds_information

A request to delete "master" should probably be signed, I'm not familiar enough with the repo to know the policies there. This is not obviously the correct thing to do to me.

comment:2 Changed 8 months ago by gk

Status: needs_informationnew
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

tor-browser has no own master branch as we only use feature branches
and did so in the past. If you look at the master branch that got
erroneously committed it's just some random Mozilla branch not
containing any Tor Browser patches pushed by any of us.

So, yes, please remove it.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE1LbTp/1VD4Q+DIDnfkOLWrkXMD4FAl3493gACgkQfkOLWrkX
MD7wew//dr9XFClG5Hfpx+qkAPhidPSCAsivgluyfTyydGOIfnt6QpDfUKPzesf9
DL7fSdIlMgMTMfWB9KEE3FFaG9U19iBbInH8aay0xZ9AtpUKX2nTgrUS2xRqCnhA
VZeX8DZf2J+FLRuL+1xEuwJ8Mxdp9hJnPFtaWaVNc9XQ4sS3Nv251nNm7P4MDYVT
NEULq2ayDRriHBTV+EXCLDQg6d5aXJINfkRxzUmmEbr7gFxcTnXbcN46BfNeXkPK
biKzsvjSVTT4ZqK9CJHMFhtsl2vaumIr2JEAeyqOwlccxRUXFF05lhUrjKzKxdzI
NvvcvPycHureNzgN96ORkOB9TngpsNSpnBxBONm1H3hwKZf9URJNoTYbTWydO4Ln
outEZAdHYXeGik268wVsv/RYMVG5aoUNtsEVIoaPaO/Cnxs7/oU8Le+dcyEeBAoB
IAsuVxwSBpeZI1iVCrIa8WprW2ALd3jTZYIOXVRSNbeyiOTmC4RLQVL/rKGCCyow
EEuF0VPCbOIZlyVn/J4V8n4LbX+HsBhWu0SURhb2lNPoTaOYScCr3Lkg5LciTTyk
wXvlFXLKKTj8PCoGDLqAxi+Ekjfuo9sPK6OVgnz2/uaWV7kJoRRnq9GzbdH91zba
9cp0DTcHKYV0kTsLdAR89e4NmAHzhGvAT25eiurHEKjQ6iuQuFA=
=0zN0
-----END PGP SIGNATURE-----

comment:3 Changed 6 months ago by irl

Owner: changed from tor-gitadm to ahf
Status: newassigned

Same steps as #33183

comment:4 Changed 5 months ago by irl

Owner: changed from ahf to irl
Status: assignedaccepted

I'll take these to get them done

comment:5 Changed 5 months ago by irl

Resolution: fixed
Status: acceptedclosed

Additionally, I've added a rule to prevent master from being push to the tor-browser.git repo again because that's just confusing.

Note: See TracTickets for help on using tickets.