Opened 10 months ago

Closed 5 months ago

#32765 closed defect (fixed)

Use CHECK_PRINTF with tor_assertion_failed_() and tor_bug_occurred_().

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: consider-backport-if-needed, 041-backport 042-backport bugsmashfund
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: dgoulet Sponsor:

Description

I just noticed that these two printf-like functions don't declare CHECK_PRINTF(), possibly leading to bugs elsewhere in our code.

Child Tickets

Change History (7)

comment:1 Changed 10 months ago by nickm

Actual Points: .1
Keywords: 041-backport 042-backport bugsmashfund added; backport removed
Points: .1

See branch bug32765_041 with PR at https://github.com/torproject/tor/pull/1611 .

This turned up a bug in 0.4.2; I'll open another ticket for that.

comment:2 Changed 10 months ago by dgoulet

Status: assignedneeds_review

comment:3 Changed 10 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

ACK.

comment:4 Changed 10 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.1.x-final

Merged to 0.4.2 and forward; marking for possible backport.

comment:5 Changed 9 months ago by teor

Keywords: consider-backport-after-0431 added

comment:6 Changed 9 months ago by teor

Keywords: consider-backport-if-needed added; consider-backport-after-0431 removed

We don't think that we need to backport this ticket, but we're leaving it open in case we want to backport it later.

comment:7 Changed 5 months ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final
Resolution: fixed
Status: merge_readyclosed

Not going to backport to 0.4.1.

Note: See TracTickets for help on using tickets.