Opened 11 months ago

Closed 9 months ago

#32767 closed enhancement (fixed)

Remove Disconnect search as it is discontinued

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202001R, 9.5a5
Cc: Actual Points: 0.25
Parent ID: Points: 0.25
Reviewer: boklm Sponsor:

Description

It just forwards to DuckDuckGo, so it is useless.

Child Tickets

Change History (6)

comment:1 Changed 10 months ago by pili

Keywords: TorBrowserTeam202001 added
Points: 0.25

comment:2 Changed 10 months ago by acat

Actual Points: 0.25
Keywords: TorBrowserTeam202001R added; TorBrowserTeam202001 removed
Status: newneeds_review

comment:3 Changed 9 months ago by boklm

Reviewer: boklm

comment:4 Changed 9 months ago by sysrqb

Status: needs_reviewneeds_revision

Can you create this as a fixup! on "Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing" (1d63bba60069585d820b5ae7508ed69fb36f92c0) instead of a new commit? Are all modifications from that original commit?

comment:5 in reply to:  4 ; Changed 9 months ago by acat

Status: needs_revisionneeds_review

Replying to sysrqb:

Can you create this as a fixup! on "Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing" (1d63bba60069585d820b5ae7508ed69fb36f92c0) instead of a new commit? Are all modifications from that original commit?

Yes, all are modifications from that commit. Done as a fixup in ​https://github.com/acatarineu/tor-browser/commit/32767+1.

We might want to reword this and the test commit in the next rebase, since Disconnect is not there anymore.

comment:6 in reply to:  5 Changed 9 months ago by sysrqb

Keywords: 9.5a5 added
Resolution: fixed
Status: needs_reviewclosed

Replying to acat:

Replying to sysrqb:

Can you create this as a fixup! on "Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing" (1d63bba60069585d820b5ae7508ed69fb36f92c0) instead of a new commit? Are all modifications from that original commit?

Yes, all are modifications from that commit. Done as a fixup in ​https://github.com/acatarineu/tor-browser/commit/32767+1.

Thanks! Merged as bfe5efa2e8eaac36bc9930fa1437b1a70045532b.

We might want to reword this and the test commit in the next rebase, since Disconnect is not there anymore.

That's a good point, I'll try remember this during the rebase.

Note: See TracTickets for help on using tickets.