Opened 8 months ago

Closed 6 months ago

Last modified 6 months ago

#32791 closed task (fixed)

Fix some errors in tor's python scripts

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 043-should, tor-python-3
Cc: Actual Points: 0.1
Parent ID: #33193 Points: 1
Reviewer: Sponsor:

Description

We've added __future__ statements to all our scripts, and done some testing, but we should check the output of all our python scripts.

Child Tickets

Change History (8)

comment:1 Changed 6 months ago by teor

Keywords: 043-should added; 043-can removed

This PR generates a list of python 3 print function errors:
https://github.com/torproject/tor/pull/1686

Now that we have a list of errors, we should fix them in 0.4.3.

comment:2 Changed 6 months ago by teor

Actual Points: 0.1
Status: newneeds_review

Here's a partial fix PR from a new contributor:

We should review and merge this fix, and then do more testing, to make sure we haven't missed anything.

comment:3 Changed 6 months ago by dgoulet

Status: needs_reviewnew

I've merged PR 1687, lgtm.

However I ran flake8 and I still get issues. The ./scripts/codegen/makedesc.py script is failing with python 3 starting with:

Traceback (most recent call last):
  File "./scripts/codegen/makedesc.py", line 27, in <module>
    import UserDict
ModuleNotFoundError: No module named 'UserDict'

Obviously more things to do. Putting this one back to New.

comment:4 Changed 6 months ago by teor

Status: newneeds_revision

comment:5 Changed 6 months ago by teor

Status: needs_revisionmerge_ready

Let's merge this PR:
https://github.com/torproject/tor/pull/1703

It's a very simple change, which looks good to me.

We can also run flake8 again, if we want.

comment:6 Changed 6 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged it; thanks!

comment:7 Changed 6 months ago by teor

Parent ID: #33196
Summary: Check all of Tor's python scripts run under python 3Fix some errors in tor's python scripts

comment:8 Changed 6 months ago by teor

Parent ID: #33196#33193
Note: See TracTickets for help on using tickets.