Opened 3 months ago

Closed 2 weeks ago

Last modified 5 days ago

#32792 closed task (fixed)

Copy chutney CI diagnostics to Tor's chutney job

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: consider-backport-after-ci-passes, 044-should, tor-ci, chutney, 035-backport, 041-backport, 042-backport, 043-backport, network-team-roadmap-2020Q1
Cc: Actual Points: 0.3
Parent ID: #33050 Points: 0.1
Reviewer: nickm Sponsor: Sponsor55-must

Description

In #32630, we improved chutney's CI diagnostics on failure. We should also run those diagnostics in tor's chutney CI job.

Child Tickets

Change History (10)

comment:1 Changed 2 months ago by teor

Keywords: 044-should added; 043-should removed
Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

I can do this in 0.4.4.

comment:2 Changed 6 weeks ago by teor

Parent ID: #33232
Sponsor: Sponsor55-must

We need to make this change as part of Sponsor 55's chutney improvements. Otherwise, it is going to be hard to diagnose failures in Tor's chutney CI.

comment:3 Changed 6 weeks ago by teor

Actual Points: 0.1
Parent ID: #33232#33050
Reviewer: nickm

comment:4 Changed 6 weeks ago by teor

Status: assignedneeds_review

Oops

comment:5 Changed 6 weeks ago by teor

(This ticket is not urgent, please review whenever you have time.)

comment:6 Changed 5 weeks ago by nickm

Resolution: implemented
Status: needs_reviewclosed

lgtm; merged!

comment:7 Changed 2 weeks ago by teor

Keywords: 035-backport 041-backport 042-backport 043-backport added
Milestone: Tor: 0.4.4.x-finalTor: 0.4.3.x-final
Resolution: implemented
Status: closedreopened

Turns out we actually want to have these diagnostics all the way back to 0.3.5.

Some of the chutney changes I've made recently have made 0.3.5 unreliable.

comment:8 Changed 2 weeks ago by teor

Actual Points: 0.10.2
Keywords: consider-backport-after-ci-passes added
Status: reopenedmerge_ready

Marking for backport after CI passes, because:

  • the code has already been reviewed
  • the new code only runs when CI fails, and we need these diagnostics when CI fails

See my PR:

Test branches are here:

comment:9 Changed 2 weeks ago by teor

Actual Points: 0.20.3
Milestone: Tor: 0.4.3.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

One macOS job hung, monitoring that issue on #32804.

Merged to 0.3.5 and later.

comment:10 Changed 5 days ago by gaba

Keywords: network-team-roadmap-2020Q1 added

Add all the tickets from sponsor 55 that are done and being worked on to the keyword #network-team-roadmap-2020Q1 so I can look at them in the wiki page...

Note: See TracTickets for help on using tickets.