Opened 2 months ago

Closed 5 weeks ago

#32806 closed enhancement (implemented)

Move "easy" dirauth-only options to dirauth module

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-design, 043-can
Cc: nickm Actual Points: 0.5
Parent ID: #32139 Points:
Reviewer: teor Sponsor:

Description

For this ticket, I'll be moving all of the easy, simple dirauth configuration options to the appropriate module.

I'm defining options as "easy" if they aren't currently used anywhere outside the dirauth module, the config module, and the tests.

For other dirauth-only options, I'll want to do some refactoring first.

Child Tickets

Change History (8)

comment:1 Changed 2 months ago by nickm

See branch ticket32807 ticket32806 with PR at https://github.com/torproject/tor/pull/1619 .

I'll put this in needs_review once CI is done. I recommend reviewing it one commit at a time; the individual commits are fairly simple, but there are a bunch of them.

Last edited 2 months ago by nickm (previous) (diff)

comment:2 Changed 2 months ago by nickm

Actual Points: 0.5

comment:3 Changed 2 months ago by nickm

Status: assignedneeds_review

comment:4 Changed 7 weeks ago by dgoulet

Reviewer: teor

comment:5 Changed 6 weeks ago by nickm

Keywords: 043-can added

tag all currently needs_review tickets with 043-can. (Since there's code before the feature freeze, maybe we can take it.)

comment:6 Changed 5 weeks ago by teor

Status: needs_reviewneeds_revision
Type: defectenhancement

Looks good, there's a bit of unused code you can delete if you like, and a comment that got a little mangled.
Feel free to merge after fixing those issues.

What's the plan to test these changes?
There are some unit tests and chutney tests, but the coverage isn't great.

Should we run the code on moria1 before merging? Or shortly after merging?

comment:7 Changed 5 weeks ago by nickm

yeah -- moria has to be the testing plan here; we usually get good testing there during our alpha series once we merge dirauth stuff.

comment:8 Changed 5 weeks ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Merged!

Note: See TracTickets for help on using tickets.