Standardise EXPOSE and INTERNAL macros to PRIVATE

We should rename all our EXPOSE and INTERNAL macros to PRIVATE.

Then we can simplify the PRIVATE patterns in #32798 (moved) and #32522 (moved).

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #32798 (moved)

added actualpoints::0.2 component::core tor/tor milestone::Tor: 0.4.3.x-final owner::teor parent::32798 points::0.5 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed type::task labels

I also standardised PRIVATE_ to PRIVATE.

The only unusual change is renaming CHANNEL_PRIVATE_ and TOR_CHANNEL_INTERNAL_ to CHANNEL_FILE_PRIVATE and CHANNEL_OBJECT_PRIVATE. Otherwise, they would have been ambiguous.

See my PR:

• master: https://github.com/torproject/tor/pull/1623

Trac:
Status: assigned to needs_review
Actualpoints: N/A to 0.2
Reviewer: N/A to nickm

Here's how I searched for replacements:

$ grep -r '#.*if.*def.*[A-Z_]*\(INTERNAL\|EXPOSE\)[A-Z_]*' src | grep -v -e 'src/ext' -e 'include.am'
src/lib/err/backtrace.h:#ifdef EXPOSE_CLEAN_BACKTRACE
src/lib/err/backtrace.h:#endif /* defined(EXPOSE_CLEAN_BACKTRACE) */
...
src/core/or/channeltls.h:#ifdef TOR_CHANNEL_INTERNAL_
src/core/or/channeltls.h:#endif /* defined(TOR_CHANNEL_INTERNAL_) */
src/core/or/channel.h:#ifdef TOR_CHANNEL_INTERNAL_
src/core/or/channel.h:#endif /* defined(TOR_CHANNEL_INTERNAL_) */
...
src/feature/dirparse/routerparse.h:#ifdef EXPOSE_ROUTERDESC_TOKEN_TABLE
$ grep -r '#.*if.*def.*PRIVATE_' src | grep -v -e 'src/ext' -e 'include.am'
src/core/or/scheduler.h:#ifdef SCHEDULER_PRIVATE_
src/core/or/scheduler.h:#endif /* defined(SCHEDULER_PRIVATE_) */
src/core/or/channel.h:#ifdef CHANNEL_PRIVATE_
src/core/or/channel.h:#endif /* defined(CHANNEL_PRIVATE_) */

lgtm; merged!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 4h

added 1h 36m of time spent

mentioned in issue #32798 (moved)

moved to tpo/core/tor#32818 (closed)