Opened 5 weeks ago

Last modified 29 hours ago

#32822 needs_revision enhancement

Make authorities add their own IPv6 address to trusted dir servers

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6
Cc: Actual Points: 0.4
Parent ID: Points: 0.2
Reviewer: dgoulet Sponsor:

Description

Authorities add themselves to trusted dir servers, but they don't add their own IPv6 addresses.

Child Tickets

Change History (7)

comment:1 Changed 5 weeks ago by teor

Status: assignedneeds_review

This ticket depends on a new function added in #32588.

See my PR:

comment:2 Changed 2 weeks ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewneeds_revision

One CI build fails with asserts. I just seen that one in another ticket of yours. Might not be related to the fix itself?

In any case, putting back in needs revision to figure that one out.

comment:3 Changed 2 weeks ago by teor

Actual Points: 0.20.3
Status: needs_revisionneeds_review

I also forgot to check for an empty IPv6 address in this patch (in a different way to the last one).

I re-did the patch, so I could rewrite the commit message.

I still need to write some tests, but I'd like a review :-)

comment:4 Changed 2 weeks ago by dgoulet

Status: needs_reviewneeds_revision

Couple comments on PR. Nothing crazy! looks good!

comment:5 Changed 9 days ago by teor

I made some fixes, but I still need to do unit tests, so I'm leaving it in needs_revision.

comment:6 Changed 7 days ago by teor

Actual Points: 0.30.4

I added some tests for authority IPv6 ORPort config parsing. They don't actually use the authority IPv6 ORPort self-add feature, but they do increase the coverage of the related config code.

comment:7 Changed 29 hours ago by teor

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

Let's do this in 0.4.4: it's a feature, and there's no need to add it at the last minute.

Note: See TracTickets for help on using tickets.