Make authorities add their own IPv6 address to trusted dir servers

Authorities add themselves to trusted dir servers, but they don't add their own IPv6 addresses.

changed milestone to %Tor: 0.4.4.x-final

added 044-can actualpoints::0.4 component::core tor/tor ipv6 milestone::Tor: 0.4.4.x-final owner::teor points::0.2 priority::medium reviewer::dgoulet severity::normal status::merge-ready type::enhancement labels

This ticket depends on a new function added in #32588 (moved).

See my PR:

• master: https://github.com/torproject/tor/pull/1626

Trac:
Status: assigned to needs_review

One CI build fails with asserts. I just seen that one in another ticket of yours. Might not be related to the fix itself?

In any case, putting back in needs revision to figure that one out.

Trac:
Status: needs_review to needs_revision
Reviewer: N/A to dgoulet

I also forgot to check for an empty IPv6 address in this patch (in a different way to the last one).

I re-did the patch, so I could rewrite the commit message.

I still need to write some tests, but I'd like a review :-)

Trac:
Actualpoints: 0.2 to 0.3
Status: needs_revision to needs_review

Couple comments on PR. Nothing crazy! looks good!

Trac:
Status: needs_review to needs_revision

I made some fixes, but I still need to do unit tests, so I'm leaving it in needs_revision.

I added some tests for authority IPv6 ORPort config parsing. They don't actually use the authority IPv6 ORPort self-add feature, but they do increase the coverage of the related config code.

Trac:
Actualpoints: 0.3 to 0.4

Let's do this in 0.4.4: it's a feature, and there's no need to add it at the last minute.

Trac:
Milestone: Tor: 0.4.3.x-final to Tor: 0.4.4.x-final

I'll look at this ticket again some time during 0.4.4.

Trac:
Keywords: N/A deleted, 044-should added

It's unlikely that I'll ever write tests for this feature, but someone else is welcome to do that, and then merge.

(Or merge without tests, if they think the code is simple enough.)

Putting this in needs_review to see what we think here.

Trac:
Status: needs_revision to needs_review

This is fine by me tbh. I think we could merge this. Ideal world is unit tests but there is just so much we can do I guess.

Trac:
Status: needs_review to merge_ready

hm, it looks like this is based on #32588 (moved), which is already merged in master. Dgoulet, do you have a sense which of these patches we should merge and how we should take them?

Trac:
Keywords: 044-should deleted, 044-can added

changed time estimate to 1h 36m

added 3h 12m of time spent

moved to tpo/core/tor#32822 (closed)