Opened 5 months ago

Last modified 4 months ago

#32831 needs_information enhancement

create JAR artifacts for consuming geoip files in Android apps

Reported by: eighthave Owned by:
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: Android, tbb-mobile
Cc: n8fr8 Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

For Android apps, JAR files in Maven repositories are the standard way to use libraries. The _geoip_ and _geoip6_ files are a kind of library of data. So this adds the -make-maven-artifacts option to _src/config/mmdb-convert.py_ to generate the standard Maven artifacts of these datafiles that are directly consumable in a standard Android build setup, e.g. in _build.gradle_:

    implementation 'org.torproject:geoip:20191217'

These should be reproducible running them anywhere, since the timestamps come from the MaxMind file.

https://github.com/torproject/tor/pull/1631

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by teor

Milestone: Tor: 0.4.4.x-final
Status: newneeds_review
Type: defectenhancement

Sorry we missed this ticket, it didn't have a milestone, and it wasn't in needs_review.

I've put it in 0.4.4 and in needs_review, so someone should review it in the next week or two.

comment:2 Changed 4 months ago by dgoulet

Reviewer: ahf

comment:3 Changed 4 months ago by ahf

Status: needs_reviewneeds_information

I think the patch looks OK, but I'm unsure if this script is the best place for this logic? Isn't it smarter to do this conversion outside of tor.git like when Orbot did/does the conversion of the binaries (the zip files with mp3 file ending)?

comment:4 Changed 4 months ago by eighthave

The patch is an extension of the existing script that is in tor.git, that's why I submitted it there. It really doesn't matter where it lives since the geoip generation is really a standalone thing. It does not make sense to move it into some other project's repo. If you want to move it out of tor.git, make it a standalone git repo.

The zip files with the mp3 file ending are a 11+ year old hack that was obsolete at least 7 years ago. We really should let that die.

Note: See TracTickets for help on using tickets.