Opened 10 months ago

Last modified 5 months ago

#32871 needs_information defect

Static linking issue with OpenSSL

Reported by: ffontaine Owned by:
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: backport? 043-can
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

There is a static linking issue with OpenSSL, link order of libz must be adjusted to solve bug with static linking and host paths must be removed when looking for openssl.

The patch is available at https://git.buildroot.net/buildroot/tree/package/tor/0001-Fix-static-linking-with-OpenSSL.patch

Child Tickets

Change History (9)

comment:1 Changed 10 months ago by arma

Status: newneeds_review

comment:2 Changed 10 months ago by nickm

Milestone: Tor: 0.4.3.x-final

comment:3 Changed 10 months ago by dgoulet

Reviewer: nickm

comment:4 Changed 10 months ago by nickm

Keywords: backport? added

comment:5 Changed 10 months ago by nickm

Neat; this looks plausible to me at first glance.

I'm making a PR so that our CI can have a look at it: https://github.com/torproject/tor/pull/1638

It looks to me like this patch might already be getting used in production somewhere; could you tell me more about that, so I can know how it's been tested?

comment:6 Changed 9 months ago by nickm

I'm not so good at linking issues, so I'm having a hard time verifying that this behaves differently than our current makefile. Could you walk me through a setup where static linking fails without this patch, but succeeds with it?

(For me, the process fails either way, because autoconf fails to define HAVE_SSL_SESSION_GET_MASTER_KEY.)

comment:7 Changed 9 months ago by nickm

Status: needs_reviewneeds_information

comment:8 Changed 9 months ago by nickm

Keywords: 043-can added

We can take this in 0.4.3 if somebody gives me instructions on how to reproduce this.

comment:9 Changed 5 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

0.4.3 was released: Move non merge-ready 0.4.3 tickets to 044.

Note: See TracTickets for help on using tickets.