Opened 5 months ago

Closed 9 days ago

#32873 closed enhancement (fixed)

'GETINFO status/fresh-relay-descs' error message unhelpful

Reported by: atagar Owned by: neel
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: neel Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Hi network team. Recently we added a stem integ test for 'GETINFO status/fresh-relay-descs' which in practice fails quite a bit with...

Error generating descriptor

This comes from tor. I'm dropping this test from Stem. It might be useful for tor to provide a more explicit error message if we'd care for this to be a reliable and useful GETINFO option.

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by atagar

Ahhh, the log has the underlying reason...

Jan 03 15:10:57.267 [warn] Don't know my address while generating descriptor

This explains why the test passes ~70% of the time (sometimes we've bootrapped sufficiently to get an address, and sometimes we don't). There are two issues here...

  1. The control port's error response should get this reason rather than the log.
  1. If determining our address is a lengthy process our spec should state that it is a requirement for this GETINFO option and how to check if it is available.

comment:2 Changed 5 months ago by nickm

I agree with your suggestions above.

As a workaround for now, you can set the Address option to an IP. You might need to set other options for Tor to accept a private IP address, but it should work.

comment:3 Changed 5 months ago by atagar

Perfect! Thanks Nick, I'll give that a whirl so we can keep the test.

comment:4 Changed 5 months ago by dgoulet

Milestone: Tor: unspecified

comment:5 Changed 7 weeks ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:6 Changed 7 weeks ago by neel

Type: defectenhancement

comment:7 Changed 7 weeks ago by neel

Status: assignedneeds_review

comment:8 Changed 7 weeks ago by asn

Reviewer: asn

comment:9 Changed 9 days ago by asn

Resolution: fixed
Status: needs_reviewclosed

Merged! Thanks!

Note: See TracTickets for help on using tickets.