Opened 10 months ago

Closed 9 months ago

#32892 closed defect (implemented)

chan: Remove dead function command_process_var_cell()

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-chan
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description

With channel_set_cell_handlers(), two handlers are set in a channel which are for fixed size cell and variable length cell.

Turns out that the channel->var_cell_handler is never used since all var cell are processed through the channel TLS layer directly:

connection_or_process_cells_from_inbuf()

-> channel_tls_handle_var_cell().

Which means we can remove a good 70+ lines of dead code.

Child Tickets

Change History (6)

comment:1 Changed 10 months ago by dgoulet

Status: assignedneeds_review

Branch: ticket32892_043_01
PR: https://github.com/torproject/tor/pull/1642

comment:2 Changed 9 months ago by dgoulet

Reviewer: nickm

comment:3 Changed 9 months ago by nickm

Looks okay; should we also remove the declaration of the channel_cell_handler_fn_ptr type?

comment:4 Changed 9 months ago by nickm

Status: needs_reviewneeds_revision

comment:5 Changed 9 months ago by dgoulet

Status: needs_revisionneeds_review

I assume you meant channel_var_cell_handler_fn_ptr and if so yes, I just pushed a fixup for it.

comment:6 Changed 9 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Squashed and merged!

Note: See TracTickets for help on using tickets.