Opened 2 weeks ago

Last modified 10 hours ago

#32905 merge_ready defect

Remove the ClientAutoIPv6ORPort option

Reported by: neel Owned by: neel
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: ipv6
Cc: neel Actual Points:
Parent ID: #29641 Points:
Reviewer: dgoulet Sponsor:

Description (last modified by neel)

In #27490, we introduced the option ClientAutoIPv6ORPort, which randomly tries IPv4 or IPv6 randomly.

This option is not true Happy Eyeballs and fails very often, usually trying IPv6 on networks which are IPv4-only (#30639).

We should remove this option.

Child Tickets

TicketStatusOwnerSummaryComponent
#30639closedTor tries to connect over IPv6 in IPv4 networks with ClientAutoIPv6ORPort setCore Tor/Tor
#32942closedneelDeprecate the ClientAutoIPv6ORPort optionCore Tor/Tor

Change History (9)

comment:1 Changed 2 weeks ago by neel

Description: modified (diff)
Keywords: ipv6 added
Milestone: Tor: unspecified
Version: Tor: unspecified

comment:4 Changed 10 days ago by neel

Status: assignedneeds_review

comment:5 Changed 9 days ago by teor

Status: needs_reviewneeds_revision

Since this option has been present in tor for a few releases, we should deprecate it in one release, and then remove it in the next release,

Please open a separate ticket to deprecate the option in the deprecation table:
https://gitweb.torproject.org/tor.git/tree/src/app/config/config.c#n819
We can merge that ticket into the current master.

Then, after we split off the next release, we can merge this ticket into master.
(And revert the changes to the deprecation table.)

comment:6 Changed 7 days ago by neel

Milestone: Tor: unspecifiedTor: 0.4.4.x-final
Status: needs_revisionneeds_review

I deprecated ClientAutoIPv6ORPort in ticket #32942 (commit 8d288eb3a7738e50a371db63d83ea37f4cfb67fb).

Setting as needs review for 0.4.4.x.

comment:7 Changed 42 hours ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

This is 0.4.4 and merge window hasn't opened yet.

comment:8 Changed 10 hours ago by teor

Parent ID: #30639

comment:9 Changed 10 hours ago by teor

Parent ID: #29641
Note: See TracTickets for help on using tickets.