Opened 7 months ago

Closed 5 months ago

#32905 closed enhancement (fixed)

Remove the ClientAutoIPv6ORPort option

Reported by: neel Owned by: neel
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6
Cc: neel Actual Points:
Parent ID: #29641 Points:
Reviewer: dgoulet Sponsor:

Description (last modified by neel)

In #27490, we introduced the option ClientAutoIPv6ORPort, which randomly tries IPv4 or IPv6 randomly.

This option is not true Happy Eyeballs and fails very often, usually trying IPv6 on networks which are IPv4-only (#30639).

We should remove this option.

Child Tickets

TicketTypeStatusOwnerSummary
#30639defectclosedTor tries to connect over IPv6 in IPv4 networks with ClientAutoIPv6ORPort set
#32942defectclosedneelDeprecate the ClientAutoIPv6ORPort option

Change History (15)

comment:1 Changed 7 months ago by neel

Description: modified (diff)
Keywords: ipv6 added
Milestone: Tor: unspecified
Version: Tor: unspecified

comment:4 Changed 7 months ago by neel

Status: assignedneeds_review

comment:5 Changed 7 months ago by teor

Status: needs_reviewneeds_revision

Since this option has been present in tor for a few releases, we should deprecate it in one release, and then remove it in the next release,

Please open a separate ticket to deprecate the option in the deprecation table:
https://gitweb.torproject.org/tor.git/tree/src/app/config/config.c#n819
We can merge that ticket into the current master.

Then, after we split off the next release, we can merge this ticket into master.
(And revert the changes to the deprecation table.)

comment:6 Changed 7 months ago by neel

Milestone: Tor: unspecifiedTor: 0.4.4.x-final
Status: needs_revisionneeds_review

I deprecated ClientAutoIPv6ORPort in ticket #32942 (commit 8d288eb3a7738e50a371db63d83ea37f4cfb67fb).

Setting as needs review for 0.4.4.x.

comment:7 Changed 7 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

This is 0.4.4 and merge window hasn't opened yet.

comment:8 Changed 7 months ago by teor

Parent ID: #30639

comment:9 Changed 7 months ago by teor

Parent ID: #29641

comment:10 Changed 7 months ago by teor

Type: defectenhancement
Version: Tor: unspecified

comment:11 Changed 6 months ago by dgoulet

Status: merge_readyneeds_revision

@neel, Hi! There is a merge conflict with latest git master because the tor.1.txt file has been re-ordered. You think you can rebase your branch on latest master?

If not, that is fine, I can take a shot and try to resolve the conflict. Thanks!

comment:12 Changed 6 months ago by neel

Status: needs_revisionneeds_review

I couldn't merge the changes on the existing branch but I have moved the changes to a new PR: https://github.com/torproject/tor/pull/1751

comment:13 Changed 5 months ago by dgoulet

Status: needs_reviewneeds_revision

CI fails. The src/test/conf_examples/large_1/expected_no_dirauth file still has a reference to ClientAutoIPv6ORPort.

Else this lgtm.

comment:14 Changed 5 months ago by neel

Status: needs_revisionneeds_review

Should be good now.

comment:15 Changed 5 months ago by dgoulet

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged!

Note: See TracTickets for help on using tickets.