Opened 7 months ago

Last modified 2 months ago

#32907 accepted enhancement

Remove or_options_t dependencies from module config headers

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 043-deferred 044-can
Cc: Actual Points:
Parent ID: #32798 Points: 0.5
Reviewer: Sponsor:

Description (last modified by teor)

The following inline header functions depend on some members of or_options_t, which is a dependency we don't need:

  • options_validate_dirauth_mode()
  • options_validate_server_transport()
  • options_validate_relay_mode()

And the dependency only exists when the relay or dirauth modules are disabled.

Instead, we could put these functions in stub C files, which are only compiled when relay/dirauth mode is disabled.

Child Tickets

Change History (6)

comment:1 Changed 7 months ago by teor

Description: modified (diff)

Make description clearer.

comment:2 Changed 7 months ago by nickm

Parent ID: #32764

Unparenting to close parent.

comment:3 Changed 7 months ago by teor

Parent ID: #32798

If we do this task, we'll be able to compile more headers by themselves, in all compilation modes,

comment:4 Changed 6 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:5 Changed 6 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

comment:6 Changed 2 months ago by nickm

Keywords: 044-can added
Owner: set to nickm
Status: newaccepted
Type: defectenhancement
Note: See TracTickets for help on using tickets.