Opened 12 days ago

Last modified 8 days ago

#32907 new defect

Remove or_options_t dependencies from module config headers

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #32798 Points: 0.5
Reviewer: Sponsor:

Description (last modified by teor)

The following inline header functions depend on some members of or_options_t, which is a dependency we don't need:

  • options_validate_dirauth_mode()
  • options_validate_server_transport()
  • options_validate_relay_mode()

And the dependency only exists when the relay or dirauth modules are disabled.

Instead, we could put these functions in stub C files, which are only compiled when relay/dirauth mode is disabled.

Child Tickets

Change History (3)

comment:1 Changed 12 days ago by teor

Description: modified (diff)

Make description clearer.

comment:2 Changed 11 days ago by nickm

Parent ID: #32764

Unparenting to close parent.

comment:3 Changed 8 days ago by teor

Parent ID: #32798

If we do this task, we'll be able to compile more headers by themselves, in all compilation modes,

Note: See TracTickets for help on using tickets.