Tor Manual: Split Node options into their own subsection

Let's put the client Node and GeoIPExcludeUnknown options in their own manpage section.

For context, see: https://trac.torproject.org/projects/tor/ticket/32846#comment:11

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #4310 (moved)

added 043-can component::core tor/tor documentation easy extra-review manpage milestone::Tor: 0.4.3.x-final parent::4310 points::0.5 priority::medium resolution::implemented reviewer::catalyst reviewer::nickm severity::normal status::closed tor-client type::task labels

Trac:
Username: swati
Reviewer: N/A to catalyst, teor
Status: new to needs_review

Added a new section called Advanced Options for grouping all the *Node related options. See PR - ​https://github.com/torproject/tor/pull/1702

Currently, there are 9 options in this section.

Some questions:

• Is Advanced Options an appropriate title for this category?
• Does the NodeFamily option belong to this section?

Trac:
Username: swati

Thanks!

It mostly looks good to me. I think "Node selection options" might be a better section title, because they restrict the nodes a tor client (or onion service) can use while building a circuit. There should also probably be introductory text explaining that these options can weaken your anonymity by making your client behavior different from other Tor clients.

I'll try to comment more after the weekend.

Trac:
Keywords: documentation tor-client manpage easy 043-can deleted, documentation tor-client manpage easy 043-can extra-review added

Hi, I'm busy with Sponsor 55 right now, can you find someone else to review?

Trac:
Reviewer: catalyst, teor to catalyst

Taylor, please feel free to add any other reviewer to this ticket.

Replying to teor:

Hi, I'm busy with Sponsor 55 right now, can you find someone else to review?

Trac:
Username: swati

Replying to swati:

• Does the NodeFamily option belong to this section? After looking at it some more, it does seem like NodeFamily belongs in this section. Anyone else have opinions on this?

Trac:
Reviewer: catalyst to catalyst, nickm

Taylor, I changed the section title to 'Node Selection Options', and also added some introductory text. Please review.

Replying to catalyst:

Thanks!

It mostly looks good to me. I think "Node selection options" might be a better section title, because they restrict the nodes a tor client (or onion service) can use while building a circuit. There should also probably be introductory text explaining that these options can weaken your anonymity by making your client behavior different from other Tor clients.

I'll try to comment more after the weekend.

Trac:
Username: swati

Replying to swati:

Taylor, I changed the section title to 'Node Selection Options', and also added some introductory text. Please review.

Thanks!

Please also move NodeFamily to this section, as you asked about before.

Minor: I think the two sentences of introductory text should be a single paragraph, and only the sentence immediately preceding the list of options should have a colon at the end.

Replying to catalyst:

Taylor, I changed the section title to 'Node Selection Options', and also added some introductory text. Please review.

Thanks!

Please also move NodeFamily to this section, as you asked about before.

Minor: I think the two sentences of introductory text should be a single paragraph, and only the sentence immediately preceding the list of options should have a colon at the end.

Done both! Combined the text in the introductory paras, and added the NodeFamily option in this section.

Trac:
Username: swati

Note to merger: see #32928 (moved) for special merge instructions.

Trac:
Status: needs_review to merge_ready

Awesome! I've followed the instructions on #32928 (moved) and merged PR 1711; I believe that has merged this work too. Please reopen if I'm closing this in error.

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

changed time estimate to 4h

moved to tpo/core/tor#32929 (closed)