Opened 9 months ago

Closed 9 months ago

#32976 closed enhancement (fixed)

Bundle geckodriver for Linux in Tor Browser output

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam202001R, GeorgKoppen202001
Cc: sysrqb Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I was looking at tor-browser-selenium for a non-performance-measurement related task and got told to "Install geckodriver from the geckodriver releases page". I could not find any GPG signature or some other way to authenticate the binary (apart from having it fetched over TLS) which makes me feel a bit uneasy.

So, how about building geckodriver during our build and bundle it in our release directory as we do for other auxiliary tools as well? Another benefit of doing so is having always the proper geckodriver available for running a respective Tor Browser. No need anymore to figure out which of the download options from the website to choose from with the risk of running into weird errors. The costs are additional size for the whole browser directory (although only 2MB per arch) and slightly higher code complexity.

I can work on that ticket of a patch would be accepted.

Child Tickets

Change History (4)

comment:1 Changed 9 months ago by gk

Oh, while thinking more about it and not knowing anything in detail about the upcoming QA ramp-up for the release train transition: it could be helpful having the proper geckodriver artifact handy when having regular test runs during our QA process.

comment:2 Changed 9 months ago by boklm

Building geckodriver during our build sounds like a good idea to me.

comment:3 Changed 9 months ago by gk

Keywords: tbb-rbm TorBrowserTeam202001R GeorgKoppen202001 added
Status: newneeds_review

I looked at this bug over the weekend: bug_32976_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32976_v3&id=f531a004aaa169d9a4a06a3b6d7c04c6fd812f9c) has a patch up for review that is working for me at least.

comment:4 Changed 9 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good and also works for me, so I merged it to master with commit e1127b38167b902a1b77b14b8c06cfbce9bae653.

Note: See TracTickets for help on using tickets.