Opened 9 months ago

Closed 8 months ago

Last modified 8 months ago

#32991 closed defect (fixed)

TBB Project For ZSTD

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, TorBrowserTeam202003R
Cc: sysrqb, sisbell, tbb-team Actual Points: 1
Parent ID: #28704 Points:
Reviewer: Sponsor:

Description (last modified by sisbell)

Create a tbb project to build source code targeting the android platform.

Source is at

https://github.com/facebook/zstd

Zstandard - Fast real-time compression algorithm. This is used to compress data sent over tor. This compression is useful over slower mobile networks.

We will compile this into tor with --enable-zstd flag.

Child Tickets

Change History (17)

comment:1 Changed 9 months ago by boklm

What do you mean by "Android Project For ZSTD"?

comment:2 Changed 9 months ago by cypherpunks

Build with zstd flag for lib support since it exists

comment:3 Changed 9 months ago by sisbell

Description: modified (diff)

comment:4 Changed 9 months ago by sisbell

Description: modified (diff)

comment:5 Changed 9 months ago by sisbell

Description: modified (diff)

comment:6 Changed 9 months ago by pili

Keywords: TorBrowserTeam202002 added; TorBrowserTeam202001 removed

Moving tickets to February

comment:7 Changed 9 months ago by sisbell

Summary: Android Project For ZSTDTBB Project For ZSTD

comment:8 Changed 8 months ago by sysrqb

Status: newneeds_revision

This is based on commit 191e603664aa5eba0ae670a48af1cb6501248372 from ticket:28704#comment:23.

+git_hash: 'v[% c("version") %]'

Does Facebook sign their git tags for zstd? If not, then we should use the git commit hash instead.

comment:9 in reply to:  8 Changed 8 months ago by sisbell

Replying to sysrqb:

This is based on commit 191e603664aa5eba0ae670a48af1cb6501248372 from ticket:28704#comment:23.

+git_hash: 'v[% c("version") %]'

Does Facebook sign their git tags for zstd? If not, then we should use the git commit hash instead.

No zstd does not have a signed tag (but does have a signed commit)

comment:10 Changed 8 months ago by gk

Keywords: tbb-parity removed

No parity involved here, we don't have this on desktop yet, see: #22341.

comment:11 Changed 8 months ago by sisbell

Using commit hash, there is no signed tag. Also added correct variant of clang in build file since we are moving ANDROID_NDK path to after system path.

https://github.com/sisbell/tor-browser-build/commits/bug-32991

Last edited 8 months ago by sisbell (previous) (diff)

comment:12 Changed 8 months ago by sisbell

Status: needs_revisionneeds_review

comment:13 Changed 8 months ago by boklm

Keywords: TorBrowserTeam202002R added; TorBrowserTeam202002 removed

comment:14 Changed 8 months ago by eighthave

Cc: hans@… removed

comment:15 Changed 8 months ago by sisbell

Keywords: TorBrowserTeam202003R added; TorBrowserTeam202002R removed

comment:16 Changed 8 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I cherry-picked the patch on master as commit e96c9adc8857312871349cf5cfa3dcead71a3ff6.

comment:17 Changed 8 months ago by sisbell

Actual Points: 1
Note: See TracTickets for help on using tickets.