Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#33012 closed task (fixed)

Remove unneeded namecoin and snowflake definitions in rbm.conf

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam202001R
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: Sponsor:

Description

After discussing a similar issue in #32435, we noticed that we have some lines in rbm.conf that explicitly disable namecoin and snowflake but are not really needed.

When I want to see if a feature is enabled/disable I usually look at all the lines setting the option, so I find it better to have less lines to look at. So I think it's better if we remove the definitions that are not needed.

I think an exception to that rule would be if we wanted to add a comment explaining why we a feature is disabled (however it seems we don't have this case yet).

An other exception is the line setting var/multi_lingual to 0. In this case, we don't set it anywhere else, so I think it's useful to keep it to remind us that the option exists and can be changed.

So if everybody agrees with that rule, I think we should remove the snowflake: 0 and namecoin: 0 lines from rbm.conf.

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by boklm

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: newneeds_review

comment:2 Changed 4 weeks ago by gk

Keywords: TorBrowserTeam202001R added; TorBrowserTeam201901R removed
Resolution: fixed
Status: needs_reviewclosed

Fine with me. Merged to master (commit 6c245925b40b13f8508ca3ade45425338a56acdf). I guess you could think about starting to write down those rules somewhere. There are a bunch IIRC and it might help both code reviewers and folks wanting to contribute patches if they were explicit.

comment:3 in reply to:  2 Changed 4 weeks ago by boklm

Replying to gk:

I guess you could think about starting to write down those rules somewhere. There are a bunch IIRC and it might help both code reviewers and folks wanting to contribute patches if they were explicit.

That's a good idea. I opened #33013 for that.

comment:4 Changed 4 weeks ago by boklm

Actual Points: .1
Note: See TracTickets for help on using tickets.