Refactor hs configuration parsing

We accidentally duplicate a lot of our configuration parsing logic for our hs_config.c stuff. We should use our confmgt code instead, to detect duplicate options, malformed options, and so on.

changed milestone to %Tor: 0.4.4.x-final

Trac:
Child Ticket(s): #33460 (moved)

added 044-must actualpoints::.3 component::core tor/tor milestone::Tor: 0.4.4.x-final network-team-roadmap-2020Q1 onionbalance owner::nickm points::1 priority::medium resolution::fixed reviewer::dgoulet scaling severity::normal status::closed tor-hs tor-spec type::defect labels

I've started work here in a local branch called hs_options_modernize.

Trac:
Keywords: tor-hs scaling onionbalance tor-spec network-team-roadmap-2020Q1 044-must deleted, scaling, 044-must, tor-spec, network-team-roadmap-2020Q1, tor-hs, onionbalance added

Trac:
Parent: #32709 (moved) to N/A

I've got hs_options_modernize working, and it makes the hs config functions far less loop-driven. I'll want to rebase it on #33460 (moved) once that is merged, however, so that there isn't a usability regression.

Trac:
Actualpoints: N/A to .3

hs_options_modernize is now updated and rebased, with a pull request at https://github.com/torproject/tor/pull/1775 . I think it makes the code a bit neater. What do you think?

Trac:
Status: assigned to needs_review

Did a pass at it. Good stuff! I like very much that new config interface! :)

Oh and travis warning: https://travis-ci.org/torproject/tor/jobs/658743268#L1028

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to needs_revision

Thanks for the review! I've pushed some changes here.

Trac:
Status: needs_revision to needs_review

whoops, don't know why it wasn't needs_review.

Weird failure on one single build on travis:

https://travis-ci.org/github/torproject/tor/jobs/659887242#L5008

I added one comment, leave it to your discretion to fix or not. I can merge once we figure out the CI issue or else feel free to do so.

This is great change! :) Thanks!

Trac:
Status: needs_review to needs_revision

The CI issue was that a new header wasn't listed in include.am, so distcheck was failing. I've pushed a fix.

Which comment is it that you added? I can't find anything on that ticket in the last 10 days...

Trac:
Status: needs_revision to needs_review

Failed again :(

https://travis-ci.org/github/torproject/tor/jobs/667348564#L3453

Trac:
Status: needs_review to needs_revision

Fixed, I hope? I verified that make distcheck now works on my desktop for this branch -- but we should let CI finish anyway.

Trac:
Status: needs_revision to needs_review

CI is passing now :)

Missing changes file. I added it in commit ec8d41e69931bc717b41831928c720b21719c67f.

Merged!!!! Thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

changed time estimate to 8h

added 2h 24m of time spent

mentioned in issue #33460 (moved)

moved to tpo/core/tor#33014 (closed)