Opened 4 months ago

Last modified 4 months ago

#33060 new defect

Check that consensus timestamp lists is initialied and has at list one item

Reported by: juga Owned by:
Priority: Medium Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version: sbws: 1.1.0
Severity: Normal Keywords:
Cc: juga Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Working on #30909 realized that even if I realized that when checking if len(self._consensus_timestamps) >= 1, in the case that self._consensus_timestamps wouldn't not be initialized, it'd give a type error.
That doesn't currently happen because that code is call after the __init__ method. It'd still be safer to to check that it's been initialized.

Child Tickets

Change History (1)

comment:1 Changed 4 months ago by juga

Work in https://github.com/juga0/sbws/tree/maint-1.1_bug33060. Not changing ticket to needs review cause this is not a blocking bug.

Note: See TracTickets for help on using tickets.