Opened 4 weeks ago

Last modified 3 weeks ago

#33095 merge_ready defect

Don't say "future instances of this warning will be suppressed" when we don't mean it.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: consider-backport-after-0433 041-backport 042-backport
Cc: Actual Points:
Parent ID: Points: .1
Reviewer: Sponsor:

Description

Some of our definitions of the BUG() macro pass 1 as once to tor_bug_occurred_(), causing it to claim that we're only warning once.

Child Tickets

Change History (5)

comment:1 Changed 4 weeks ago by nickm

Keywords: 035-backport removed
Status: assignedaccepted

comment:2 Changed 4 weeks ago by nickm

Status: acceptedneeds_review

Branch is bug33095_041 with PR at https://github.com/torproject/tor/pull/1697 . Should merge forward cleanly to master.

comment:3 Changed 4 weeks ago by dgoulet

Milestone: Tor: 0.4.3.x-finalTor: 0.4.2.x-final
Status: needs_reviewmerge_ready

lgtm; Merged it to master (043). Moving milestone to 042 for backport.

comment:4 Changed 3 weeks ago by teor

Keywords: consider-backport-after-0433 added

comment:5 Changed 3 weeks ago by teor

Keywords: 043-should removed
Note: See TracTickets for help on using tickets.